force: Vault NonceManagerKind::Safe for aggregator - #1152
Merged
Conversation
reecepbcups
changed the title
reecepbcups
marked this pull request as ready for review
May 23, 2026 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fast approach caused a retry condition which required a restart of WAVS. i think this is the 3rd time we have hit it in production.
WAVS is still on v2.0.0-rc.14, so building a specific vault image for us there. We can make this proper in the future (either removing or making it a config option or something)
ref: https://lay3r.slack.com/archives/C0A7JL2K337/p1779554921215579?thread_ts=1779532743.735499&cid=C0A7JL2K337
What happened: The aggregator went to push the rebalance last night @ 3am eastern. The aggregator did not have enough balance to do it. This pushed the tx into the re-try queue. This queue in the aggregator has a max of 1000 retries stored in memory.
This morning I funded the aggregator with $20 in ETH but it still did not submit on chain. There was an optimization in the aggregator to use an in memory nonce queue which while faster, can cause many issues when you get out of nonce sync - i.e. like retries. SO it would try to submit txs with an invalid nonce via the re-try queue
hacky fix: restarted wavs-1