Simplify getenv FFI binding - #432
Open
shonfeder wants to merge 2 commits into
Open
Conversation
`Sys.gentenv_opt` was introduced in OCaml 4.05, and since the current compiler lower bound for elpi is 4.13, we know it will be available. Using it here allows us to forgo a try/with, and manual wrapping of the happy path in a `Some`. This also lets us correct the documentation, which referred to `Sys.getenv` tho the implementation provided matches the behaviour of `Sys.getenv_opt`.
Looks like noisy, specious failures from having variable IDs in test fixtures?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sys.gentenv_optwas introduced in OCaml 4.05, and since the current compiler lower bound for elpi is 4.13, we know it will be available. Using it here allows us to forgo a try/with, and manual wrapping of the happy path in aSome.This also lets us correct the documentation, which referred to
Sys.getenvtho the implementation provided matches the behaviour ofSys.getenv_opt.This is essentially just a stylistic fix I noticed while prepping for #427. I'll take offense if its not suitable for some reason, but any feedback in that case to guide the other work will be welcomed gratefully :)