Run tests/tests.exe from dune - #433
Open
shonfeder wants to merge 1 commit into
Open
Conversation
By running tests/tests.exe we can ensure that any other executables dune
is aware of will be available for the tests/test.exe. It will also
ensure that the `tests/test.exe` is up to date before being run.
This suggestion is motivated by test failures on my machine, due to the
inability to locate `ydump` executable, which is an implicit dependency
assumed by tests/suite/suite.ml. Development environments using the
right opam switch will have `ydump` available in the environment, but
other environments may not (I'm using dune package management). If these
tests were being run inside dune, we'd specify `ydump` as a dependency
to be made available on the path via `%{bin:ydumb}`.
Contributor
|
Looks good, but are env variable preserved by dune exec? |
Contributor
|
Just to be sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By running
tests/tests.exewithdune execwe can ensure that any other executables dune is aware of will be available for thetests/test.exe. It will also ensure that thetests/test.exeis up to date before being run.This suggestion is motivated by a test failures encountered in my dev env while working on #432, due to the inability to locate the
ydumpexecutable (provided by yocaml), which is an implicit dependency assumed bytests/suite/suite.ml:elpi/tests/suite/suite.ml
Line 502 in 18e079b
Development environments using the right opam switch will have
ydumpavailable in the environment, but other environments may not (E.g., i'm using dune package management). If these tests were being run inside dune, we'd specifyydumpas a dependency to be made available on the path via%{bin:ydumb}, but that's obviously not available from the Makefile.