feat: add is_reliably_broadcasted helper to Outgoing struct - #49
Closed
thefauxpastrouper wants to merge 2 commits into
Closed
Conversation
Signed-off-by: ADITYA SWAROOP <adityakumar997399@gmail.com>
survived
requested changes
Jul 13, 2026
|
|
||
| /// Checks whether it's a reliable broadcast message | ||
| pub fn is_reliably_broadcasted(&self) -> bool { | ||
| self.recipient.is_reliable_broadcast() |
Contributor
There was a problem hiding this comment.
The method should be called .is_reliable_broadcast() to mirror the name of the method on MessageDestination.
"is reliably broadcasted" implies that the message was already broadcasted, however, it's yet to be sent.
Signed-off-by: thefauxpastrouper <work.adityaswaroop@gmail.com>
thefauxpastrouper
deleted the
feature/add-outgoing-is-reliably-broadcasted
branch
July 14, 2026 14:24
thefauxpastrouper
restored the
feature/add-outgoing-is-reliably-broadcasted
branch
July 14, 2026 14:25
Contributor
Author
|
Sorry for the delay. I have renamed the method to is_reliable_broadcast and added the required DCO sign-off. Ready for another look! |
thefauxpastrouper
deleted the
feature/add-outgoing-is-reliably-broadcasted
branch
July 14, 2026 14:35
thefauxpastrouper
restored the
feature/add-outgoing-is-reliably-broadcasted
branch
July 14, 2026 14:37
thefauxpastrouper
deleted the
feature/add-outgoing-is-reliably-broadcasted
branch
July 14, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48