Skip to content

feat: add is_reliable_broadcast helper to Outgoing struct - #50

Merged
survived merged 1 commit into
LFDT-Lockness:mfrom
thefauxpastrouper:feature/add-outgoing-is-reliable-broadcast
Jul 17, 2026
Merged

feat: add is_reliable_broadcast helper to Outgoing struct#50
survived merged 1 commit into
LFDT-Lockness:mfrom
thefauxpastrouper:feature/add-outgoing-is-reliable-broadcast

Conversation

@thefauxpastrouper

Copy link
Copy Markdown
Contributor

Replaces closed PR #49

Solves the issue #48

Sorry for the delay. I have renamed the method to is_reliable_broadcast and added the required DCO sign-off. Ready for another look!

This branch has the renamed method is_reliable_broadcast and a clean, signed-off commit history.

@thefauxpastrouper

Copy link
Copy Markdown
Contributor Author

I have also changed the branch name to feature/add-outgoing-is-reliable-broadcast

@survived

Copy link
Copy Markdown
Contributor

Hi @thefauxpastrouper, thanks for the update. Can you GPG sign your commit? We will not be able to merge otherwise

@survived

Copy link
Copy Markdown
Contributor

(see the contribution guidelines)

Signed-off-by: thefauxpastrouper <work.adityaswaroop@gmail.com>
@thefauxpastrouper
thefauxpastrouper force-pushed the feature/add-outgoing-is-reliable-broadcast branch from 881bcec to 40d3752 Compare July 16, 2026 01:54
@thefauxpastrouper

Copy link
Copy Markdown
Contributor Author

I've updated the commit with the GPG signature. Sorry for not following the guidelines initially, I will make sure it doesn't happen next time. Thanks for your patience!

@thefauxpastrouper

Copy link
Copy Markdown
Contributor Author

I saw you mention the force push guideline on another PR. The force push was just to get the GPG signature applied as requested, but I'll make sure to use standard commits moving forward.

@survived

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

@survived
survived merged commit f45c8ed into LFDT-Lockness:m Jul 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants