Skip to content

fix(ci): backport daily prerelease bootstrap to default branch - #1246

Merged
XingYu-Zhong merged 1 commit into
KunAgent:masterfrom
luoye520ww:codex/fix-daily-dev-semver-master
Aug 30, 2026
Merged

fix(ci): backport daily prerelease bootstrap to default branch#1246
XingYu-Zhong merged 1 commit into
KunAgent:masterfrom
luoye520ww:codex/fix-daily-dev-semver-master

Conversation

@luoye520ww

Copy link
Copy Markdown
Collaborator

Summary

Backports the Daily Dev prerelease bootstrap fix to the repository default branch, where scheduled workflows are loaded.

Companion to #1242, which keeps develop consistent. This PR targets master because GitHub schedule events use the workflow definition from the default branch before the job checks out develop.

Changes

  • remove the pre-install require("semver") dependency from the version step
  • validate the exact generated 0.0.0-dev-YYYYMMDD-HHMM value with built-in JavaScript

Tests

  • npm ci (exit 0)
  • node scripts/check-extension-release-gate-workflows.mjs (exit 0)
  • PyYAML parse of .github/workflows/daily-dev-prerelease.yml (exit 0)
  • valid/mismatched/malformed version matrix (exit 0)
  • git diff --check origin/master..HEAD (exit 0)

Review

Sol Medium independent review: Blocker 0, High 0, Medium 0; Ready.

Actual validation

After merge, the next scheduled run must be observed to confirm that the default-branch workflow reaches the platform build jobs. This cannot be exercised from a fork PR because schedule events load from the upstream default branch.

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as the default-branch companion to #1242. The workflow blob transition is identical, removes the pre-install semver dependency from the schedule-loaded master workflow, and keeps the checkout of develop build contents unchanged. All four package checks pass. Merge this together with #1242 so master schedules are fixed now and a later develop-to-master sync cannot restore the old step.

@XingYu-Zhong
XingYu-Zhong merged commit 8981734 into KunAgent:master Aug 30, 2026
5 checks passed
XingYu-Zhong added a commit that referenced this pull request Aug 30, 2026
Revert the #1246 workflow change from master because changes must land through develop. The dependency removal remains in develop via #1242.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants