Skip to content

fix(ci): remove prerelease semver bootstrap dependency - #1242

Merged
XingYu-Zhong merged 2 commits into
KunAgent:developfrom
luoye520ww:codex/fix-daily-dev-semver
Aug 30, 2026
Merged

fix(ci): remove prerelease semver bootstrap dependency#1242
XingYu-Zhong merged 2 commits into
KunAgent:developfrom
luoye520ww:codex/fix-daily-dev-semver

Conversation

@luoye520ww

Copy link
Copy Markdown
Collaborator

Summary

Restore the Daily Dev Prerelease prepare job, which currently fails before any platform build starts because it requires semver before dependencies are installed.

Recent runs 33187362921, 33223408802, and 33248594729 all stop in Compute dev version with MODULE_NOT_FOUND: semver.

Changes

  • remove the prepare job's undeclared runtime dependency on semver
  • validate the generated version against the exact canonical 0.0.0-dev-YYYYMMDD-HHMM value derived from dev_version
  • preserve the existing date-format validation and all output values

Tests

  • dependency-free reproduction before the fix: node -e 'require("semver")' exits 1 with MODULE_NOT_FOUND
  • canonical valid pair accepted with exit 0
  • mismatched app version rejected with exit 1
  • malformed dev version rejected with exit 1
  • workflow YAML parse passed
  • node scripts/check-extension-release-gate-workflows.mjs passed
  • git diff --check passed

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking deployment issue: scheduled workflows are loaded from the repository default branch, which is currently master, while this PR targets develop. Run 33270203067 (and the preceding scheduled runs) has headBranch=master and still executes the old inline require("semver") step even though actions/checkout later checks out develop. The replacement logic in this PR is correct, but merging it only to develop will not restore the scheduled job. Please pair this with the repository-approved master/default-branch backport or sync path, then verify a scheduled run reaches the platform jobs. Local workflow contract/YAML/diff checks pass.

@luoye520ww

Copy link
Copy Markdown
Collaborator Author

Addressed the default-branch deployment-path blocker with companion backport #1246 targeting \master. The backport is a single commit directly atop current master and contains only the workflow bootstrap fix; #1242 remains the develop-side change. Local workflow contract/YAML/version-matrix/diff checks pass. After #1246 merges, I will verify that the next scheduled run reaches the platform jobs.

@XingYu-Zhong XingYu-Zhong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment blocker from my earlier review is now resolved: companion PR #1246 has merged the identical workflow fix into the default branch master (merge commit 8981734). This PR should also merge into develop so future branch synchronization cannot restore the dependency. The replacement validation is correct and all PR checks pass.

@XingYu-Zhong
XingYu-Zhong merged commit 02d4629 into KunAgent:develop Aug 30, 2026
5 checks passed
XingYu-Zhong added a commit that referenced this pull request Aug 30, 2026
Revert the #1246 workflow change from master because changes must land through develop. The dependency removal remains in develop via #1242.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants