Skip to content

fix lineCharacterOffset generating a negative value #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maverck wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix lineCharacterOffset generating a negative value #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ec7e99
fix lineCharacterOffset generating a negative value
Jun 16, 2020
9048972
extension crashes if iterator.getPosition() is undefined
Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/utils/contextUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export class BackwardIterator {
const document: TextDocument = this.getDocument();
const lineRange: Range = document.lineAt(lineNumber).range;
const lineText: string = this.documentStateContext.sanitizedDocumentText.slice(document.offsetAt(lineRange.start), document.offsetAt(lineRange.end));
lineCharacterOffset = lineText.length - 1;
lineCharacterOffset = Math.max(0, lineText.length - 1);
} else {
return undefined;
}
Expand Down Expand Up @@ -901,7 +901,7 @@ export function getStartSigPosition(iterator: BackwardIterator): Position | unde
while (iterator.hasNext()) {
const ch: number = iterator.next();

if (stringRanges) {
if (stringRanges && iterator.getPosition()) {
const position: Position = iterator.getPosition().translate(0, 1);
const stringRange: Range = stringRanges.find((range: Range) => {
return range.contains(position) && !range.end.isEqual(position);
Expand Down