fix lineCharacterOffset generating a negative value - #51
Open
maverck wants to merge 2 commits into
Open
Conversation
|
Can this be merged , this seems to prevent issues where I have to restart VSCode to resolve them currently |
|
Ping!? could this be merged ? |
|
@KamasamaK just wondering if you saw this merge request? |
|
This is fixed in my latest fork https://github.com/garethedwards-tass/vscode-cfml turns out the fix was more involved than this specific change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lineCharacterOffset = lineText.length - 1;
this line results in a negative value sometimes? and the extension crashes and no longer provides completion.
I clamped the value so it can't be negative.