Fix incorrect vessel on launchsite warnings - #46
Merged
Conversation
…with the same name
…ordinates with a 0.2 minimum safety margin and also only check landed/splahsed vessel to not get issues with very distant planets
…nt impreciscion is a problem and otherwise the normal distance checks are more accurate.
siimav
requested changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect vessel on launchsite warnings when trying to launch from a very distant planet where the floating point impreciscion gives incorrect results. To fix this gps checks are used to compare the position but this is less accurate so it's only used when the distance is 0, see #44
Also fix some bugs with the scenario module.