(v1.12.0.0) Unable to launch from non-ksc stock bases on kerbin (Cove launch site)

[TryMyWagon]

As of the most recent update (v1.12.0.0), I am unable to launch from the Cove launch site, and presumably any of the other stock/dlc sites (discoverable and dlc included - tested Cove site, Woomerang, and Desert). Only Modded launch sites + the default ksc launchpad & runway continue to function as normal.

I am running an extremely heavy modlist and I'm unable to recreate a clean install at the moment so I'm unsure weather this issue is universal or a conflict, but just incase its a core issue I figured I might as well put my findings here.

I can confirm that v1.11.0.0 works perfectly fine for me. I took a quick look over PR #46 and did some testing in visual studio. It seems the changes made in v1.12.0.0 causes the other launch sites to not be added to List<KKLaunchSite> AllLaunchSites in LaunchSiteManager.cs, at least on my game.

When pressing the launch icon with one of the sites selected, the game triggers an input lock and then nothing happens, just stuck in the vab until the lock is cleared, heres the relevant log msg

[ERR 21:05:27.527] KK: GetLaunchSiteByName: Could not find Launchsite in list: Desert_Launch_Site

[ERR 21:05:27.528] KK: GetLaunchSiteByName: Could not find Launchsite in list: Desert_Launch_Site

[ERR 21:05:27.528] KK: GetLaunchSiteByName: Could not find Launchsite in list: Desert_Launch_Site

[LOG 21:05:27.529] [Pre-Flight Check]: Checking for CraftWithinPartCountLimit: PASS!
[LOG 21:05:27.529] [Pre-Flight Check]: Checking for CraftWithinSizeLimits: PASS!
[LOG 21:05:27.529] [Pre-Flight Check]: Checking for CraftWithinMassLimits: PASS!
[LOG 21:05:27.530] [Pre-Flight Check]: Checking for ExperimentalPartsAvailable: PASS!
[LOG 21:05:27.530] [Pre-Flight Check]: Checking for CanAffordLaunchTest: PASS!
[LOG 21:05:27.530] [Pre-Flight Check]: Checking for NoControlSources: PASS!
[ERR 21:05:27.530] KK: GetLaunchSiteByName: Could not find Launchsite in list: Desert_Launch_Site

[EXC 21:05:27.532] NullReferenceException: Object reference not set to an instance of an object
    KerbalKonstructs.Core.LaunchSiteChecks.VesselAtLaunchSite (ProtoVessel vessel, KerbalKonstructs.Core.KKLaunchSite launchSite, System.Single maxDistance, System.String landedAt) (at <fab37c9c1bfd44a4986f976ace84fb7c>:0)
    KerbalKonstructs.Core.LaunchSiteChecks.FindVesselsLandedAtKK (FlightState flightState, System.String landedAt, System.Int32& count, System.String& name, System.Int32& idx, VesselType& vType) (at <fab37c9c1bfd44a4986f976ace84fb7c>:0)
    PreFlightTests.LaunchSiteClear.Test () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PreFlightCheck.runNextTest () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PreFlightCheck.runNextTest () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PreFlightCheck.runNextTest () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PreFlightCheck.runNextTest () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PreFlightCheck.runNextTest () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PreFlightCheck.runNextTest () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PreFlightCheck.runNextTest () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    PreFlightCheck.RunTests () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    EditorLogic.launchVessel (System.String siteName) (at <4b449f2841f84227adfaad3149c8fdba>:0)
    KSP.UI.Screens.EditorLaunchPadItem.MouseInput_Launch () (at <4b449f2841f84227adfaad3149c8fdba>:0)
    UnityEngine.Events.InvokableCall.Invoke () (at <12e76cd50cc64cf19e759e981cb725af>:0)
    UnityEngine.Events.UnityEvent.Invoke () (at <12e76cd50cc64cf19e759e981cb725af>:0)
    UnityEngine.UI.Button.Press () (at <0c883c16262a4198973f823d01e07427>:0)
    UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <0c883c16262a4198973f823d01e07427>:0)
    UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <0c883c16262a4198973f823d01e07427>:0)
    UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <0c883c16262a4198973f823d01e07427>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.EventSystems.EventSystem:Update()

I'm not confident enough in c# to try and diagnose let alone make a confident pr but hopefully this post is useful if anyone else has this issue :D

[Dalewyn]

Just commenting to affirm that I'm also experiencing this problem with the symptoms exactly as described: An NRE trying to launch from Desert Airfield.

My install is (probably) nowhere as modded as OP, and downgrading from 1.12.0.0 to 1.11.0.0 fixed the problem.

[Clayell]

It seems the changes made in v1.12.0.0 causes the other launch sites to not be added to List AllLaunchSites in LaunchSiteManager.cs, at least on my game.

Just making a note that this is incorrect. The changes in v1.12.0.0 made no change to stock launchsites not being added to that list, and it seems that the code was designed to not have the launchsites in that list at all. The only thing wrong was that a null reference exception was preventing the method from executing, when it should have returned early. (what my PR does)