Skip to content

Support 4-arg :module form#711

Merged
topolarity merged 1 commit into
JuliaDebug:masterfrom
topolarity:ct/4arg-module
Mar 17, 2026
Merged

Support 4-arg :module form#711
topolarity merged 1 commit into
JuliaDebug:masterfrom
topolarity:ct/4arg-module

Conversation

@topolarity

@topolarity topolarity commented Mar 3, 2026

Copy link
Copy Markdown
Member

This should keep things working after JuliaLang/julia#60018 introduced a new module form.

Co-authored-by: Claude <noreply@anthropic.com>

@codecov

codecov Bot commented Mar 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.69%. Comparing base (376d172) to head (ec922ee).
⚠️ Report is 92 commits behind head on master.

Files with missing lines Patch % Lines
src/construct.jl 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   81.03%   84.69%   +3.66%     
==========================================
  Files          12       12              
  Lines        2636     2745     +109     
==========================================
+ Hits         2136     2325     +189     
+ Misses        500      420      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Keno pushed a commit to JuliaLang/julia that referenced this pull request Mar 4, 2026
This allows tools like Revise to re-parse Base source files using the
correct syntax version.

This (+ timholy/Revise.jl#1016 /
JuliaDebug/JuliaInterpreter.jl#711) is enough
for `Revise.track(Base)` to work for me to revise local changes to
`base/loading.jl`, etc.

Co-authored-by: Claude \<noreply@anthropic.com\>
Co-authored-by: Claude <noreply@anthropic.com>
@topolarity

Copy link
Copy Markdown
Member Author

Nightly failures already present on master.

@Keno can you merge? I don't have rights.

@Keno

Keno commented Mar 17, 2026

Copy link
Copy Markdown
Member

@Keno can you merge? I don't have rights.

Fixed that.

@topolarity
topolarity merged commit b279983 into JuliaDebug:master Mar 17, 2026
9 of 11 checks passed
@topolarity

Copy link
Copy Markdown
Member Author

Looks like I need another bit or two: 766b1c8#commitcomment-179840151

@Keno

Keno commented Mar 18, 2026

Copy link
Copy Markdown
Member

You just need to set your membership to public

@topolarity

Copy link
Copy Markdown
Member Author

Thanks! I didn't realize Github shows you the icons on your profile even for private orgs

Published

mkitti pushed a commit to mkitti/julia that referenced this pull request May 22, 2026
This allows tools like Revise to re-parse Base source files using the
correct syntax version.

This (+ timholy/Revise.jl#1016 /
JuliaDebug/JuliaInterpreter.jl#711) is enough
for `Revise.track(Base)` to work for me to revise local changes to
`base/loading.jl`, etc.

Co-authored-by: Claude \<noreply@anthropic.com\>
topolarity added a commit to topolarity/Reexport.jl that referenced this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants