Pass mod to Base.parse_input_line to support syntax versioning#1016
Merged
Conversation
Keno
reviewed
Mar 3, 2026
topolarity
force-pushed
the
ct/syntax-version
branch
from
March 3, 2026 15:11
82dec43 to
0c1815c
Compare
Keno
approved these changes
Mar 3, 2026
Keno
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Mar 4, 2026
This allows tools like Revise to re-parse Base source files using the correct syntax version. This (+ timholy/Revise.jl#1016 / JuliaDebug/JuliaInterpreter.jl#711) is enough for `Revise.track(Base)` to work for me to revise local changes to `base/loading.jl`, etc. Co-authored-by: Claude \<noreply@anthropic.com\>
Collaborator
|
Do you want to rebase this to see if CI is better now? |
Collaborator
Author
I think the JuliaInterpreter changes need to land first |
topolarity
force-pushed
the
ct/syntax-version
branch
2 times, most recently
from
March 18, 2026 00:49
8c07a2b to
14ad957
Compare
Collaborator
Author
|
CI looks much cleaner, although it still has some things to clear up. |
topolarity
force-pushed
the
ct/syntax-version
branch
from
March 30, 2026 15:45
14ad957 to
0505cb3
Compare
Co-authored-by: Claude <noreply@anthropic.com>
topolarity
force-pushed
the
ct/syntax-version
branch
from
March 30, 2026 18:47
0505cb3 to
b2ca284
Compare
Collaborator
Author
|
I had missed JuliaDebug/JuliaInterpreter.jl#712, but with that fix Revise failures match |
Collaborator
Author
|
@Keno If you can give me rights I can merge, or else feel free to merge yourself. |
Owner
|
Invite sent @topolarity. I'll let you use your new superpowers 😉 |
Collaborator
Author
|
Thanks @timholy ! |
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
May 22, 2026
This allows tools like Revise to re-parse Base source files using the correct syntax version. This (+ timholy/Revise.jl#1016 / JuliaDebug/JuliaInterpreter.jl#711) is enough for `Revise.track(Base)` to work for me to revise local changes to `base/loading.jl`, etc. Co-authored-by: Claude \<noreply@anthropic.com\>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on JuliaDebug/JuliaInterpreter.jl#711 or else this may trigger more errors.
Locally this seems to be the only missing piece for syntax versioning support (JuliaLang/julia#60018).
Co-authored-by: Claude noreply@anthropic.com