fix: links with title not parsed / LinkButton.url not populated - #121
Open
ContextFound wants to merge 2 commits into
Open
fix: links with title not parsed / LinkButton.url not populated#121ContextFound wants to merge 2 commits into
ContextFound wants to merge 2 commits into
Conversation
- Pass url parameter to LinkButton constructor in ATagMd.build() - Update link regex to support optional title attribute: [text](url "title") - Update URL extraction logic to strip title portion from raw URL Includes test infrastructure and regression tests to prevent recurrence.
Author
|
fix: default link style - the style parameter for links used a ?.copyWith(), so if nothing was passed in, it didn't apply the default formatting color of blue. Changed it to apply the default if the style is null. Validated with included test, but also validated in-app using https://github.com/ContextFound/gpt_markdown_viewer |
ContextFound
changed the title
Collaborator
|
@ContextFound We find merge conflict to this pr in complex_markdown_test.dart. Please fix this conflict before we merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown links with a well formed title do not render at all. click here displays as shown instead of creating a "click here" link. This fixes that by enhancing the regex that handles the link markdown. It also addresses an issue where widget.url is not populated effecting screen readers and debugging.
Activates previously skipped tests that prove the fixes.