fix: render markdown links that include a title attribute - #131
Closed
masfour7 wants to merge 4 commits into
Closed
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Markdown links with a title attribute are not rendered — the raw syntax appears as plain text:
This is valid CommonMark syntax. Reported in #122, fix approach described in #121.
Root Cause
Two issues in
ATagMdinsidelib/markdown_component.dart:[^\\s]*stops matching at the first space, sourl "title"was never captured.onLinkTap.Fix
1. Broaden the regex to allow any character except
)inside the link parentheses:2. Strip the title from the URL after extraction:
The URL passed to
onLinkTapis now clean with no title string appended.Closes #122
Closes #121