Skip to content

a11y: Fix wrong content descriptions in settings dialogs #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svillar merged 1 commit into from
Sep 1, 2026
+11 −3
Merged

a11y: Fix wrong content descriptions in settings dialogs #2063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/res/layout/options_exceptions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
style="@style/customRecyclerViewStyle"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:contentDescription="privacy_options_popups_list_header_v1"
android:contentDescription="@string/privacy_options_popups_list_header_v1"
android:paddingEnd="15dp"
app:layoutManager="LinearLayoutManager" />
</LinearLayout>
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout/options_language_content.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
android:paddingEnd="15dp"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:contentDescription="@string/app_name"
android:contentDescription="@string/language_options_preferred_languages_content_description"
app:layoutManager="LinearLayoutManager" />
</LinearLayout>

Expand All @@ -76,7 +76,7 @@
android:paddingEnd="15dp"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:contentDescription="@string/app_name"
android:contentDescription="@string/language_options_available_languages_content_description"
app:layoutManager="LinearLayoutManager" />
</LinearLayout>
</LinearLayout>
Expand Down
8 changes: 8 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,6 +1724,14 @@
<!-- This string labels the description in the Content Language header for available languages list. -->
<string name="language_options_available_languages">Available Languages</string>

<!-- Accessibility content description for the list of preferred website content languages
in the 'Preferred Website Languages' dialog. -->
<string name="language_options_preferred_languages_content_description">List of preferred languages</string>

<!-- Accessibility content description for the list of available website content languages
in the 'Preferred Website Languages' dialog. -->
<string name="language_options_available_languages_content_description">List of available languages</string>

<!-- This string is for the table column name (in the browser's 'Bookmarks' list) for the 'Name' of the bookmarked website. -->
<string name="col_name">Name</string>

Expand Down
Loading