Skip to content

a11y: Fix wrong content descriptions in settings dialogs - #2063

Merged
svillar merged 1 commit into
Igalia:mainfrom
NAME-ASHWANIYADAV:fix/settings-a11y-content-descriptions
Sep 1, 2026
Merged

a11y: Fix wrong content descriptions in settings dialogs#2063
svillar merged 1 commit into
Igalia:mainfrom
NAME-ASHWANIYADAV:fix/settings-a11y-content-descriptions

Conversation

@NAME-ASHWANIYADAV

Copy link
Copy Markdown
Contributor

Fixes #2062

What

  • options_language_content.xml: the two language lists in the "Preferred Website Languages" dialog had contentDescription="@string/app_name", so TalkBack announced "Wolvic" (or the flavor's app name) when either list gained accessibility focus. They now use two new translatable strings - "List of preferred languages" / "List of available languages" - added to values/strings.xml with translator comments, following the same pattern as a11y: Label language list icons for screen readers #2040.
  • options_exceptions.xml:92: the popup-exceptions list's contentDescription was "privacy_options_popups_list_header_v1" - a literal missing its @string/ prefix, so TalkBack read the raw identifier aloud. The header TextView at :84 already uses the same string correctly with the prefix, so this just restores the intended reference.

Why

Both are wrong announcements from bad contentDescription values in settings dialogs - the first labels the lists with an unrelated string, the second exposes an internal identifier. Each fix matches its bug: the language lists needed correct strings; the exceptions list only needed the missing prefix.

Nothing in the codebase reads these values (no getContentDescription or test usages), so the change is announcement-only with no behavioral surface beyond the screen reader.

If reusing the existing visible header strings (language_options_preferred_languages / language_options_available_languages) is preferred over adding two new translatable strings, happy to switch - the dedicated-string variant was chosen to match #2040.

Testing

  • Builds: ./gradlew assembleNoapiArm64GeckoGenericDebug
  • Existing unit tests pass: ./gradlew testNoapiArm64GeckoGenericDebugUnitTest

The language lists in the Preferred Website Languages dialog announced
the app name to TalkBack, and the popup exceptions list announced a
raw resource name missing its @string/ prefix.
@NAME-ASHWANIYADAV

Copy link
Copy Markdown
Contributor Author

@svillar PTAL !!

@svillar svillar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very much appreciated the a11y fixes

@svillar svillar added the release_candidate PR that should be part of the next release label Sep 1, 2026
@svillar
svillar merged commit 04b407e into Igalia:main Sep 1, 2026
3 checks passed
@svillar svillar added this to the v1.9.1 milestone Sep 1, 2026
@svillar svillar removed the release_candidate PR that should be part of the next release label Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings dialogs announce the app name and a raw resource name to screen readers

2 participants