a11y: Fix wrong content descriptions in settings dialogs - #2063
Merged
svillar merged 1 commit intoSep 1, 2026
Merged
Conversation
The language lists in the Preferred Website Languages dialog announced the app name to TalkBack, and the popup exceptions list announced a raw resource name missing its @string/ prefix.
Contributor
Author
|
@svillar PTAL !! |
svillar
approved these changes
Sep 1, 2026
svillar
left a comment
Member
There was a problem hiding this comment.
Thanks! Very much appreciated the a11y fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2062
What
options_language_content.xml: the two language lists in the "Preferred Website Languages" dialog hadcontentDescription="@string/app_name", so TalkBack announced "Wolvic" (or the flavor's app name) when either list gained accessibility focus. They now use two new translatable strings - "List of preferred languages" / "List of available languages" - added tovalues/strings.xmlwith translator comments, following the same pattern as a11y: Label language list icons for screen readers #2040.options_exceptions.xml:92: the popup-exceptions list'scontentDescriptionwas"privacy_options_popups_list_header_v1"- a literal missing its@string/prefix, so TalkBack read the raw identifier aloud. The header TextView at:84already uses the same string correctly with the prefix, so this just restores the intended reference.Why
Both are wrong announcements from bad
contentDescriptionvalues in settings dialogs - the first labels the lists with an unrelated string, the second exposes an internal identifier. Each fix matches its bug: the language lists needed correct strings; the exceptions list only needed the missing prefix.Nothing in the codebase reads these values (no
getContentDescriptionor test usages), so the change is announcement-only with no behavioral surface beyond the screen reader.If reusing the existing visible header strings (
language_options_preferred_languages/language_options_available_languages) is preferred over adding two new translatable strings, happy to switch - the dedicated-string variant was chosen to match #2040.Testing
./gradlew assembleNoapiArm64GeckoGenericDebug./gradlew testNoapiArm64GeckoGenericDebugUnitTest