Repository navigation
ci(approve): repin gate to v1.5 #105
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ on: | |
| types: [opened, synchronize, reopened, ready_for_review] | ||
| pull_request_review: | ||
| types: [submitted] | ||
| pull_request_review_comment: | ||
| types: [created] | ||
| status: {} | ||
|
|
||
| permissions: | ||
|
|
@@ -41,4 +43,4 @@ jobs: | |
| pull-requests: write | ||
| # v1.1 -> v1.3: the referenced reusable workflow is identical at both | ||
| # tags; the bump keeps the caller on a current pin (see CHANGELOG). | ||
| uses: Icaro0310/devin-powerups/.github/workflows/pr-approve.yml@v1.5 | ||
|
Contributor
There was a problem hiding this comment. 🟡 Approval gate change lacks changelog update The Learn moreThe contribution checklist requires a changelog update. The Unreleased entry still says the approval gate uses v1.3 and calls it the current pin; this PR switches the gate to v1.5 and adds a new trigger. Example: A reader checking Unreleased after this change sees v1.3 listed as current, while the approval workflow runs v1.5. Recommended fix: Update the existing Unreleased CI entry to record the v1.5 pin and review-comment trigger. Was this helpful? React with 👍 or 👎 to provide feedback.
Owner
Author
There was a problem hiding this comment. Out of scope for this PR: the fleet repin is deliberately single-file. The gate change is recorded in devin-powerups (its changelog/tag notes); a repo changelog entry can ride along in the next regular PR.
Owner
Author
There was a problem hiding this comment. The gate change is recorded upstream: Icaro0310/devin-powerups#217 shipped v1.5 with the release notes. A repo changelog entry stays a follow-up outside this single-file PR.
Contributor
There was a problem hiding this comment. 🔍 Check external gate's comment handling The gate implementation lives outside this repository. Verify that its v1.5 tag handles review-comment events before relying on the new trigger. Was this helpful? React with 👍 or 👎 to provide feedback.
Owner
Author
There was a problem hiding this comment. Verified at the source: v1.5 of the reusable gate handles
Owner
Author
There was a problem hiding this comment. Confirmed at the source: review-comment event handling is in Icaro0310/devin-powerups#217, merged as v1.5 (c8de6b7) — the same tag this caller now pins. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Review-comment trigger lacks required tests
The new
pull_request_review_commenttrigger has no test coverage, so the changed approval behavior violates the repository's test policy.Learn more
The repository requires tests for new or changed functionality in test policy. This PR adds a new event that invokes the approval gate, but changes no tests. The existing workflow tests show how this repository tests CI configuration without invoking GitHub Actions.
Example: A later edit removes the review-comment trigger. Without a test asserting its presence and event type, the existing test suite still passes while fix-commit replies stop re-evaluating approvals.
Recommended fix: Add a workflow configuration test that checks the
pull_request_review_commentevent includescreated, alongside the job condition and reusable-workflow pin relevant to this behavior.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for this PR: the repin fleet ships an identical single-file diff (
.github/workflows/auto-approve.ymlonly). The trigger is event wiring for the reusable gate, whose own behavior is tested in its owning repo (devin-powerups). A caller-side static workflow test is a reasonable follow-up in a separate PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage for this event lives in the gate owning repo, shipped and tested in Icaro0310/devin-powerups#217 (the v1.5 this PR pins). Caller-side test additions stay out of scope for this single-file repin.