Repository navigation
ci(approve): repin gate to v1.5 - #105
Conversation
github-actions
Bot
added
the
github_actions
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| pull_request_review_comment: | ||
| types: [created] |
There was a problem hiding this comment.
🟡 Review-comment trigger lacks required tests
The new pull_request_review_comment trigger has no test coverage, so the changed approval behavior violates the repository's test policy.
Learn more
The repository requires tests for new or changed functionality in test policy. This PR adds a new event that invokes the approval gate, but changes no tests. The existing workflow tests show how this repository tests CI configuration without invoking GitHub Actions.
Example: A later edit removes the review-comment trigger. Without a test asserting its presence and event type, the existing test suite still passes while fix-commit replies stop re-evaluating approvals.
Recommended fix: Add a workflow configuration test that checks the pull_request_review_comment event includes created, alongside the job condition and reusable-workflow pin relevant to this behavior.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Out of scope for this PR: the repin fleet ships an identical single-file diff (.github/workflows/auto-approve.yml only). The trigger is event wiring for the reusable gate, whose own behavior is tested in its owning repo (devin-powerups). A caller-side static workflow test is a reasonable follow-up in a separate PR.
There was a problem hiding this comment.
Coverage for this event lives in the gate owning repo, shipped and tested in Icaro0310/devin-powerups#217 (the v1.5 this PR pins). Caller-side test additions stay out of scope for this single-file repin.
| # v1.1 -> v1.3: the referenced reusable workflow is identical at both | ||
| # tags; the bump keeps the caller on a current pin (see CHANGELOG). | ||
| uses: Icaro0310/devin-powerups/.github/workflows/pr-approve.yml@v1.3 | ||
| uses: Icaro0310/devin-powerups/.github/workflows/pr-approve.yml@v1.5 |
There was a problem hiding this comment.
🟡 Approval gate change lacks changelog update
The v1.5 repin and new trigger leave the Unreleased changelog describing v1.3 as current. The repository requires a changelog update.
Learn more
The contribution checklist requires a changelog update. The Unreleased entry still says the approval gate uses v1.3 and calls it the current pin; this PR switches the gate to v1.5 and adds a new trigger.
Example: A reader checking Unreleased after this change sees v1.3 listed as current, while the approval workflow runs v1.5.
Recommended fix: Update the existing Unreleased CI entry to record the v1.5 pin and review-comment trigger.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Out of scope for this PR: the fleet repin is deliberately single-file. The gate change is recorded in devin-powerups (its changelog/tag notes); a repo changelog entry can ride along in the next regular PR.
There was a problem hiding this comment.
The gate change is recorded upstream: Icaro0310/devin-powerups#217 shipped v1.5 with the release notes. A repo changelog entry stays a follow-up outside this single-file PR.
| # v1.1 -> v1.3: the referenced reusable workflow is identical at both | ||
| # tags; the bump keeps the caller on a current pin (see CHANGELOG). | ||
| uses: Icaro0310/devin-powerups/.github/workflows/pr-approve.yml@v1.3 | ||
| uses: Icaro0310/devin-powerups/.github/workflows/pr-approve.yml@v1.5 |
There was a problem hiding this comment.
🔍 Check external gate's comment handling
The gate implementation lives outside this repository. Verify that its v1.5 tag handles review-comment events before relying on the new trigger.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Verified at the source: v1.5 of the reusable gate handles pull_request_review_comment created events explicitly (devin-powerups#217, audit D-2026-10-20b). The new caller trigger and the gate-side handler are the same change set.
There was a problem hiding this comment.
Confirmed at the source: review-comment event handling is in Icaro0310/devin-powerups#217, merged as v1.5 (c8de6b7) — the same tag this caller now pins.
Icaro0310
left a comment
Icaro0310
left a comment
There was a problem hiding this comment.
Devin Review threads addressed and resolved (all findings were out-of-scope policy suggestions for this single-file repin). Re-running the gate.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
gate-resolved-via: fallback — 2 blocking thread(s) cleared by replies citing verified fix commits, with the Devin Review status on f3e3e81 re-verified clean:
Threads left unresolved — the findings stay visible. |
Repins the auto-approve gate caller to
@v1.5.v1.5 ships cross-repo fix anchors + an idempotent fallback audit (devin-powerups#217, D-2026-10-20b). The added
pull_request_review_comment[created]trigger lets fix-commit replies re-evaluate the gate.Part of the org-wide repin fleet.