Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions apps/extension/src/autofill.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -880,6 +880,33 @@ describe("extension automatic autofill", () => {
expect(isProfileOrRegistrationEmailField(email)).toBe(true);
});

it("uses a registration page title for generic legacy forms without overriding exclusions", () => {
const previousTitle = document.title;
document.title = "Demo Site – Registration Form – Vinoth Tech Solutions";
document.body.innerHTML = `
<form class="visual-form-builder" action="/demo-site/">
<fieldset><legend>Registration Form</legend></fieldset>
<label for="vfb-14">Email *</label>
<input type="email" name="vfb-14" id="vfb-14" class="vfb-text required email">
<input type="submit" name="vfb-submit" value="Submit">
</form>
<form id="newsletter">
<input id="newsletter-email" type="email">
<button type="submit">Subscribe</button>
</form>
<form id="contact-form">
<input id="contact-email" type="email">
<button type="submit">Submit</button>
</form>
`;

expect(isRegistrationEmailField(document.querySelector("#vfb-14"))).toBe(true);
expect(isProfileOrRegistrationEmailField(document.querySelector("#vfb-14"))).toBe(true);
expect(isRegistrationEmailField(document.querySelector("#newsletter-email"))).toBe(false);
expect(isRegistrationEmailField(document.querySelector("#contact-email"))).toBe(false);
document.title = previousTitle;
});

it("supports passwordless multi-step signup but rejects ambiguous standalone email fields", () => {
document.body.innerHTML = `
<form id="registration-step-one" action="/accounts/register">
Expand Down
11 changes: 10 additions & 1 deletion apps/extension/src/autofill.ts
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,15 @@ function registrationFormEvidence(input: HTMLInputElement): {
.join(" ");
const structural = `${form.id} ${form.className} ${form.getAttribute("name") ?? ""} ${form.getAttribute("aria-label") ?? ""} ${form.getAttribute("action") ?? ""}`;
const hint = `${structural} ${controls}`.toLocaleLowerCase();
// Some older form builders expose a completely generic <form> and "Submit" button while
// putting the only registration signal in the document title. Keep this signal deliberately
// narrow and subordinate to form-specific negative evidence so a newsletter or contact form
// embedded on a registration-themed page never receives an alias suggestion.
const pageTitle = input.ownerDocument.title.toLocaleLowerCase();
const pageTitleHasRegistrationIntent =
/(?:^|[^a-z])(?:create[-_\s]*(?:an?[-_\s]*)?account|register|registration|sign[-_\s]*up|signup)(?:[^a-z]|$)/u.test(
pageTitle,
);
return {
negative:
/(?:^|[^a-z])(?:contact|forgot|log[-_\s]*in|newsletter|recover(?:y)?|reset[-_\s]*password|search|sign[-_\s]*in|subscribe)(?:[^a-z]|$)/u.test(
Expand All @@ -760,7 +769,7 @@ function registrationFormEvidence(input: HTMLInputElement): {
positive:
/(?:^|[^a-z])(?:create[-_\s]*(?:an?[-_\s]*)?account|get[-_\s]*started|join|register|registration|sign[-_\s]*up|signup)(?:[^a-z]|$)/u.test(
hint,
),
) || pageTitleHasRegistrationIntent,
};
}

Expand Down
Loading