Fix alias suggestions on titled registration forms - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Verification
Scope: 13 of 14 workspace projects
packages/contracts typecheck$ tsc --noEmit -p tsconfig.json
packages/crypto typecheck$ tsc --noEmit -p tsconfig.json
packages/security typecheck$ tsc --noEmit -p tsconfig.json
packages/contracts typecheck: Done
packages/security typecheck: Done
packages/crypto typecheck: Done
packages/vault typecheck$ tsc --noEmit -p tsconfig.json
apps/api typecheck$ tsc --noEmit -p tsconfig.json
apps/api typecheck: Done
packages/vault typecheck: Done
packages/import-export typecheck$ tsc --noEmit -p tsconfig.json
packages/sync typecheck$ tsc --noEmit -p tsconfig.json
packages/sync typecheck: Done
packages/import-export typecheck: Done
packages/persistence typecheck$ tsc --noEmit -p tsconfig.json
packages/provider-drive typecheck$ tsc --noEmit -p tsconfig.json
packages/provider-onedrive typecheck$ tsc --noEmit -p tsconfig.json
packages/ui typecheck$ tsc --noEmit -p tsconfig.json
packages/provider-onedrive typecheck: Done
packages/provider-drive typecheck: Done
packages/persistence typecheck: Done
packages/ui typecheck: Done
apps/web typecheck$ tsc --noEmit -p tsconfig.json
apps/extension typecheck$ wxt prepare && tsc --noEmit -p tsconfig.json
apps/web typecheck: Done
apps/extension typecheck: [log]
apps/extension typecheck: WXT 0.20.27
apps/extension typecheck: [info] Generating types...
apps/extension typecheck: [success] Finished in 99 ms
apps/extension typecheck: Done
RUN v4.1.10 /Users/sujithd/Desktop/P2
Test Files 38 passed (38)
Tests 263 passed (263)
Start at 13:57:16
Duration 3.56s (transform 1.98s, setup 5.47s, import 3.22s, tests 6.78s, environment 4.72s)
Scope: 13 of 14 workspace projects
apps/api build$ WRANGLER_WRITE_LOGS=false wrangler deploy --dry-run --outdir dist
apps/api build: ⛅️ wrangler 4.114.0
apps/api build: ────────────────────
apps/api build: Total Upload: 64.88 KiB / gzip: 15.82 KiB
apps/api build: No bindings found.
apps/api build: --dry-run: exiting now.
apps/api build: Done
apps/web build$ vite build
apps/extension build$ pnpm run build:chrome && pnpm run build:firefox
apps/web build: vite v8.1.5 building client environment for production...
apps/web build: �[2K
apps/web build: transforming...✓ 43 modules transformed.
apps/web build: rendering chunks...
apps/web build: computing gzip size...
apps/web build: dist/index.html 0.81 kB │ gzip: 0.40 kB
apps/web build: dist/assets/index-DXD5oivY.css 31.12 kB │ gzip: 7.13 kB
apps/web build: dist/assets/rolldown-runtime-D9-fqq9M.js 0.08 kB │ gzip: 0.08 kB
apps/web build: dist/assets/react-runtime-DYCTgQK0.js 189.63 kB │ gzip: 59.65 kB
apps/web build: dist/assets/index-DaSuiGXE.js 190.63 kB │ gzip: 47.82 kB
apps/web build: dist/assets/crypto-runtime-DFX5EOJJ.js 533.88 kB │ gzip: 189.03 kB
apps/web build: ✓ built in 73ms
apps/web build: [plugin builtin:vite-reporter]
apps/web build: (!) Some chunks are larger than 500 kB after minification. Consider:
apps/web build: - Using dynamic import() to code-split the application
apps/web build: - Use build.rolldownOptions.output.codeSplitting to improve chunking: https://rolldown.rs/reference/OutputOptions.codeSplitting
apps/web build: - Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
apps/web build: Done
apps/extension build: $ wxt build -b chrome --mv3
apps/extension build: [log]
apps/extension build: WXT 0.20.27
apps/extension build: [info] Building chrome-mv3 for production with Vite 8.1.5
apps/extension build: - Preparing...
apps/extension build: [plugin builtin:vite-reporter]
apps/extension build: (!) Some chunks are larger than 500 kB after minification. Consider:
apps/extension build: - Using dynamic import() to code-split the application
apps/extension build: - Use build.rolldownOptions.output.codeSplitting to improve chunking: https://rolldown.rs/reference/OutputOptions.codeSplitting
apps/extension build: - Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
apps/extension build: [success] Built extension in 290 ms
apps/extension build: ├─ .output/chrome-mv3/manifest.json 1.4 kB
apps/extension build: ├─ .output/chrome-mv3/popup.html 471 B
apps/extension build: ├─ .output/chrome-mv3/background.js 653.24 kB
apps/extension build: ├─ .output/chrome-mv3/chunks/jsx-runtime-CEcHH7PL.js 617.88 kB
apps/extension build: ├─ .output/chrome-mv3/chunks/popup-Dg2Sb2PU.js 242.37 kB
apps/extension build: ├─ .output/chrome-mv3/chunks/src-DADooHFt.js 78.25 kB
apps/extension build: ├─ .output/chrome-mv3/content-scripts/autofill.js 34.26 kB
apps/extension build: ├─ .output/chrome-mv3/assets/popup-dSs2qgY-.css 46.92 kB
apps/extension build: ├─ .output/chrome-mv3/icons/icon-128.png 12.01 kB
apps/extension build: ├─ .output/chrome-mv3/icons/icon-16.png 787 B
apps/extension build: ├─ .output/chrome-mv3/icons/icon-32.png 1.98 kB
apps/extension build: ├─ .output/chrome-mv3/icons/icon-48.png 3.41 kB
apps/extension build: └─ .output/chrome-mv3/icons/icon.svg 1.43 kB
apps/extension build: Σ Total size: 1.69 MB
apps/extension build: [success] Finished in 302 ms
apps/extension build: �[1G$ wxt build -b firefox --mv3
apps/extension build: [log]
apps/extension build: WXT 0.20.27
apps/extension build: [info] Building firefox-mv3 for production with Vite 8.1.5
apps/extension build: - Preparing...
apps/extension build: [plugin builtin:vite-reporter]
apps/extension build: (!) Some chunks are larger than 500 kB after minification. Consider:
apps/extension build: - Using dynamic import() to code-split the application
apps/extension build: - Use build.rolldownOptions.output.codeSplitting to improve chunking: https://rolldown.rs/reference/OutputOptions.codeSplitting
apps/extension build: - Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
apps/extension build: [success] Built extension in 289 ms
apps/extension build: ├─ .output/firefox-mv3/manifest.json 1.52 kB
apps/extension build: ├─ .output/firefox-mv3/popup.html 471 B
apps/extension build: ├─ .output/firefox-mv3/background.js 653.24 kB
apps/extension build: ├─ .output/firefox-mv3/chunks/jsx-runtime-CEcHH7PL.js 617.88 kB
apps/extension build: ├─ .output/firefox-mv3/chunks/popup-Dg2Sb2PU.js 242.37 kB
apps/extension build: ├─ .output/firefox-mv3/chunks/src-DADooHFt.js 78.25 kB
apps/extension build: ├─ .output/firefox-mv3/content-scripts/autofill.js 34.26 kB
apps/extension build: ├─ .output/firefox-mv3/assets/popup-dSs2qgY-.css 46.92 kB
apps/extension build: ├─ .output/firefox-mv3/icons/icon-128.png 12.01 kB
apps/extension build: ├─ .output/firefox-mv3/icons/icon-16.png 787 B
apps/extension build: ├─ .output/firefox-mv3/icons/icon-32.png 1.98 kB
apps/extension build: ├─ .output/firefox-mv3/icons/icon-48.png 3.41 kB
apps/extension build: └─ .output/firefox-mv3/icons/icon.svg 1.43 kB
apps/extension build: Σ Total size: 1.69 MB
apps/extension build: [success] Finished in 301 ms
apps/extension build: �[1G
apps/extension build: Done
[log]
WXT 0.20.27
[info] Building chrome-mv3 for production with Vite 8.1.5
[success] Built extension in 287 ms
├─ .output/chrome-mv3/manifest.json 1.4 kB
├─ .output/chrome-mv3/popup.html 471 B
├─ .output/chrome-mv3/background.js 653.24 kB
├─ .output/chrome-mv3/chunks/jsx-runtime-CEcHH7PL.js 617.88 kB
├─ .output/chrome-mv3/chunks/popup-Dg2Sb2PU.js 242.37 kB
├─ .output/chrome-mv3/chunks/src-DADooHFt.js 78.25 kB
├─ .output/chrome-mv3/content-scripts/autofill.js 34.26 kB
├─ .output/chrome-mv3/assets/popup-dSs2qgY-.css 46.92 kB
├─ .output/chrome-mv3/icons/icon-128.png 12.01 kB
├─ .output/chrome-mv3/icons/icon-16.png 787 B
├─ .output/chrome-mv3/icons/icon-32.png 1.98 kB
├─ .output/chrome-mv3/icons/icon-48.png 3.41 kB
└─ .output/chrome-mv3/icons/icon.svg 1.43 kB
Σ Total size: 1.69 MB
[info] Zipping extension...
[success] Zipped extension in 143 ms
├─ .output/veyrakey-extension-0.10.0-chrome.zip 564.15 kB
└─ .output/veyrakey-extension-0.10.0-sources.zip 69.99 kB
Σ Total size: 634.13 kB
[success] Finished in 444 ms
[log]
WXT 0.20.27
[info] Building firefox-mv3 for production with Vite 8.1.5
[success] Built extension in 288 ms
├─ .output/firefox-mv3/manifest.json 1.52 kB
├─ .output/firefox-mv3/popup.html 471 B
├─ .output/firefox-mv3/background.js 653.24 kB
├─ .output/firefox-mv3/chunks/jsx-runtime-CEcHH7PL.js 617.88 kB
├─ .output/firefox-mv3/chunks/popup-Dg2Sb2PU.js 242.37 kB
├─ .output/firefox-mv3/chunks/src-DADooHFt.js 78.25 kB
├─ .output/firefox-mv3/content-scripts/autofill.js 34.26 kB
├─ .output/firefox-mv3/assets/popup-dSs2qgY-.css 46.92 kB
├─ .output/firefox-mv3/icons/icon-128.png 12.01 kB
├─ .output/firefox-mv3/icons/icon-16.png 787 B
├─ .output/firefox-mv3/icons/icon-32.png 1.98 kB
├─ .output/firefox-mv3/icons/icon-48.png 3.41 kB
└─ .output/firefox-mv3/icons/icon.svg 1.43 kB
Σ Total size: 1.69 MB
[info] Zipping extension...
[success] Zipped extension in 140 ms
├─ .output/veyrakey-extension-0.10.0-firefox.zip 564.2 kB
└─ .output/veyrakey-extension-0.10.0-sources.zip 69.99 kB
Σ Total size: 634.19 kB
[success] Finished in 441 ms
Release 0.10.0 artifact, version, permission, source-map, secret, size, and SBOM checks passed.