Fix ignored App options and release 1.1.1 - #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26. Supervisor writes /data/options.json as root with mode 0600 (supervisor/utils/json.py calls jsonfile.chmod(0o600)), so the unprivileged container user could not read it and every option silently fell back to defaults. The entrypoint now stages a readable copy into tmpfs via AI_OPTIONS_PATH and then drops privileges with su-exec, leaving the Supervisor-owned file untouched. Verified with Docker against a root-owned 0600 options file: published 1.1.0 returns refresh_interval=300 plus the permission warning, the fixed image returns 987. CI now asserts the runtime user is inspector and that a root-owned 0600 options file is read. Adds .gitattributes so the shell script cannot be checked out with CRLF. Bumps to 1.1.1.