Kh/dev/delegate legal link settings - #303
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated delegated admin settings page in the theming app for managing the “Legal notice” and “Privacy policy” URLs, including a new Vue-based UI and the corresponding PHP settings provider registration.
Changes:
- Register a new delegated admin settings provider (
OCA\Theming\Settings\AdminLegalUrls) and template for the theming admin area. - Add a new Vue settings view (
AdminLegalUrls.vue) plus a dedicated JS entrypoint (admin-legal-urls.js) to mount it. - Extend the webpack modules mapping and update theming’s composer autoload maps to include the new settings class.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.modules.js | Adds a new webpack entry for the theming admin legal URLs bundle. |
| apps/theming/templates/settings-admin-legal.php | New template mount point for the delegated legal URLs admin UI. |
| apps/theming/src/AdminLegalUrls.vue | New Vue UI for editing imprint/privacy URLs. |
| apps/theming/src/admin-legal-urls.js | Bootstraps and mounts the new Vue settings view. |
| apps/theming/lib/Settings/AdminLegalUrls.php | New delegated settings provider that supplies initial state and script. |
| apps/theming/composer/composer/autoload_static.php | Updates classmap autoload to include the new settings class. |
| apps/theming/composer/composer/autoload_classmap.php | Updates classmap autoload to include the new settings class. |
| apps/theming/appinfo/info.xml | Registers the new admin settings class in the theming app. |
bromiesTM
force-pushed
the
kh/dev/delegate-legal-link-settings
branch
from
May 11, 2026 14:01
264d435 to
c6f72ab
Compare
tanyaka
approved these changes
May 13, 2026
tanyaka
left a comment
tanyaka
left a comment
There was a problem hiding this comment.
Conflicts looks trivial. Locally works fine. Still outstanding check_release confirm after the pipelines run and conflicts resolved.
Add new admin settings page for managing legal notice and privacy policy URLs. Includes PHP settings class, Vue component, and webpack entry point. Signed-off-by: Kai Henseler <kai.henseler@strato.de>
…, add unit tests Agent-Logs-Url: https://github.com/IONOS-Productivity/ncw-server/sessions/c5d41e63-5f86-40e0-9910-8cafd7390b28 Co-authored-by: bromiesTM <78687674+bromiesTM@users.noreply.github.com> Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Expose imprintUrlDefault and privacyUrlDefault in admin settings. Use default values if custom URLs are not set. Update tests and UI. Signed-off-by: Kai Henseler <kai.henseler@strato.de>
bromiesTM
force-pushed
the
kh/dev/delegate-legal-link-settings
branch
2 times, most recently
from
May 18, 2026 08:42
7530bc6 to
e063e78
Compare
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
bromiesTM
force-pushed
the
kh/dev/delegate-legal-link-settings
branch
from
May 18, 2026 09:35
e063e78 to
1e270f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add theming admin legal URLs configuration ncw-config#159
https://github.com/IONOS-Productivity/nc-docs-and-tools/pull/138