IONOS(Theming): Add support for default legal and privacy URLs

Expose imprintUrlDefault and privacyUrlDefault in admin settings.
Use default values if custom URLs are not set. Update tests and UI.

Author: bromiesTM

apps/theming/lib/Settings/AdminLegalUrls.php

@@ -25,7 +25,9 @@ public function __construct(
 	public function getForm(): TemplateResponse {
 		$this->initialState->provideInitialState('adminLegalUrlsParameters', [
 			'legalNoticeUrl' => $this->config->getAppValue('theming', 'imprintUrl', ''),
+			'legalNoticeUrlDefault' => $this->config->getAppValue('theming', 'imprintUrlDefault', ''),
 			'privacyPolicyUrl' => $this->config->getAppValue('theming', 'privacyUrl', ''),
+			'privacyPolicyUrlDefault' => $this->config->getAppValue('theming', 'privacyUrlDefault', ''),
 		]);
 
 		Util::addScript($this->appName, 'admin-legal-urls');

apps/theming/lib/ThemingDefaults.php

@@ -101,11 +101,19 @@ public function getSlogan(?string $lang = null) {
 	}
 
 	public function getImprintUrl() {
-		return (string)$this->config->getAppValue('theming', 'imprintUrl', '');
+		$userValue = (string)$this->config->getAppValue('theming', 'imprintUrl', '');
+		if ($userValue !== '') {
+			return $userValue;
+		}
+		return (string)$this->config->getAppValue('theming', 'imprintUrlDefault', '');
 	}
 
 	public function getPrivacyUrl() {
-		return (string)$this->config->getAppValue('theming', 'privacyUrl', '');
+		$userValue = (string)$this->config->getAppValue('theming', 'privacyUrl', '');
+		if ($userValue !== '') {
+			return $userValue;
+		}
+		return (string)$this->config->getAppValue('theming', 'privacyUrlDefault', '');
 	}
 
 	public function getDocBaseUrl() {

apps/theming/src/AdminLegalUrls.vue

@@ -29,14 +29,16 @@ import TextField from './components/admin/TextField.vue'
 
 const {
 	legalNoticeUrl,
+	legalNoticeUrlDefault,
 	privacyPolicyUrl,
+	privacyPolicyUrlDefault,
 } = loadState('theming', 'adminLegalUrlsParameters')
 
 const legalFields = [
 	{
 		name: 'imprintUrl',
 		value: legalNoticeUrl,
-		defaultValue: '',
+		defaultValue: legalNoticeUrlDefault,
 		type: 'url',
 		displayName: t('theming', 'Legal notice link'),
 		placeholder: 'https://…',
@@ -45,7 +47,7 @@ const legalFields = [
 	{
 		name: 'privacyUrl',
 		value: privacyPolicyUrl,
-		defaultValue: '',
+		defaultValue: privacyPolicyUrlDefault,
 		type: 'url',
 		displayName: t('theming', 'Privacy policy link'),
 		placeholder: 'https://…',

apps/theming/tests/Settings/AdminLegalUrlsTest.php

@@ -35,19 +35,23 @@ protected function setUp(): void {
 
 	public function testGetForm(): void {
 		$this->config
-			->expects($this->exactly(2))
+			->expects($this->exactly(4))
 			->method('getAppValue')
 			->willReturnMap([
 				['theming', 'imprintUrl', '', 'https://example.com/legal'],
+				['theming', 'imprintUrlDefault', '', 'https://default.example.com/legal'],
 				['theming', 'privacyUrl', '', 'https://example.com/privacy'],
+				['theming', 'privacyUrlDefault', '', 'https://default.example.com/privacy'],
 			]);
 
 		$this->initialState
 			->expects($this->once())
 			->method('provideInitialState')
 			->with('adminLegalUrlsParameters', [
 				'legalNoticeUrl' => 'https://example.com/legal',
+				'legalNoticeUrlDefault' => 'https://default.example.com/legal',
 				'privacyPolicyUrl' => 'https://example.com/privacy',
+				'privacyPolicyUrlDefault' => 'https://default.example.com/privacy',
 			]);
 
 		$expected = new TemplateResponse('theming', 'settings-admin-legal');