Mk/review/kh/dev/base theme - #2
Merged
Merged
Conversation
printminion-co
force-pushed
the
mk/review/kh/dev/base-theme
branch
2 times, most recently
from
July 24, 2025 08:40
fdfcd33 to
87558af
Compare
this is the way Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
change folder color to the hidrive next one
lets not modify buttons in size and positioning
lets add shadow to header Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
lets remove unused code Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
* lets use defaultTheme output to override it with our values Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
mk/review/kh/dev/base-theme
branch
from
July 24, 2025 10:14
87558af to
48accba
Compare
lets keep our theme as last one in order to avoid merge conflicts in the future Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
composer run test -- apps/theming/tests/Service/ThemesServiceTest.php Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer run test -- apps/theming/tests/Service/ThemesServiceTest.phpChecklist