Kh/dev/base theme - #1
Conversation
66de91a to
7299f3c
Compare
| @@ -0,0 +1 @@ | |||
| Subproject commit 9f522a8dea4cc3141a622aaaa9845748dac11775 | |||
There was a problem hiding this comment.
- Update to latest main branch once PR is merged
| padding: 0 8px; | ||
| gap: 0; | ||
| .app-navigation-entry { | ||
| display: flex; |
There was a problem hiding this comment.
center alignment also needed for dropdown buttons
7299f3c to
1a13489
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new IONOS theme to the Nextcloud theming system, providing a branded appearance with custom styling and color schemes. The theme extends the default light theme with IONOS-specific design elements.
- Creates a new
IonosThemeclass with custom CSS styling for navigation, headers, and UI components - Registers the new theme in the theming service for system-wide availability
- Adds IONOS submodule reference for external configuration
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/theming/lib/Themes/IonosTheme.php | New theme class implementing IONOS branding with custom CSS and color variables |
| apps/theming/lib/Service/ThemesService.php | Registers IonosTheme in the themes service constructor and themes array |
| apps/theming/composer/composer/autoload_static.php | Adds IonosTheme class to autoloader mapping |
| apps/theming/composer/composer/autoload_classmap.php | Adds IonosTheme class to autoloader classmap |
| apps/theming/composer/composer/LICENSE | Removes empty lines (formatting cleanup) |
| IONOS | Adds submodule reference to IONOS configuration repository |
| .gitmodules | Configures IONOS submodule with GitHub repository URL |
Comments suppressed due to low confidence (1)
apps/theming/lib/Themes/IonosTheme.php:12
- The class extends DefaultTheme but also explicitly implements ITheme. Since DefaultTheme already implements ITheme, the explicit implementation is redundant.
class IonosTheme extends DefaultTheme implements ITheme {
| return " | ||
| #header { | ||
| #nextcloud { | ||
| padding-inline-start: 220px; | ||
| .logo { | ||
| width: 200px; | ||
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
The large CSS string should be extracted to a separate method or external file for better maintainability. The current approach makes the method difficult to read and maintain.
| return " | |
| #header { | |
| #nextcloud { | |
| padding-inline-start: 220px; | |
| .logo { | |
| width: 200px; | |
| } | |
| } | |
| return $this->getCustomCssContent(); | |
| } | |
| private function getCustomCssContent(): string { | |
| return " | |
| #header { | |
| #nextcloud { | |
| padding-inline-start: 220px; | |
| .logo { | |
| width: 200px; | |
| } | |
| } |
| // https://html.spec.whatwg.org/multipage/semantics.html#meta-color-scheme | ||
| return [[ | ||
| 'name' => 'color-scheme', | ||
| 'content' => 'ionos', |
There was a problem hiding this comment.
The meta color-scheme content should be 'light' instead of 'ionos' as 'ionos' is not a valid CSS color-scheme value. Valid values are 'light', 'dark', or 'light dark'.
| 'content' => 'ionos', | |
| 'content' => 'light', |
109c46a to
6a9a647
Compare
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
6a9a647 to
9ca50d0
Compare
Uh oh!
There was an error while loading. Please reload this page.