Skip to content

Kh/dev/base theme - #1

Merged
bromiesTM merged 2 commits into
ionos-devfrom
kh/dev/base-theme
Jul 28, 2025
Merged

Kh/dev/base theme#1
bromiesTM merged 2 commits into
ionos-devfrom
kh/dev/base-theme

Conversation

@bromiesTM

@bromiesTM bromiesTM commented Jul 16, 2025

Copy link
Copy Markdown

@bromiesTM
bromiesTM force-pushed the kh/dev/base-theme branch from 66de91a to 7299f3c Compare July 22, 2025 08:44
Comment thread IONOS Outdated
@@ -0,0 +1 @@
Subproject commit 9f522a8dea4cc3141a622aaaa9845748dac11775

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Update to latest main branch once PR is merged

padding: 0 8px;
gap: 0;
.app-navigation-entry {
display: flex;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

center alignment also needed for dropdown buttons

@bromiesTM
bromiesTM force-pushed the kh/dev/base-theme branch from 7299f3c to 1a13489 Compare July 22, 2025 09:35
@printminion-co
printminion-co requested a review from Copilot July 22, 2025 14:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new IONOS theme to the Nextcloud theming system, providing a branded appearance with custom styling and color schemes. The theme extends the default light theme with IONOS-specific design elements.

  • Creates a new IonosTheme class with custom CSS styling for navigation, headers, and UI components
  • Registers the new theme in the theming service for system-wide availability
  • Adds IONOS submodule reference for external configuration

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
apps/theming/lib/Themes/IonosTheme.php New theme class implementing IONOS branding with custom CSS and color variables
apps/theming/lib/Service/ThemesService.php Registers IonosTheme in the themes service constructor and themes array
apps/theming/composer/composer/autoload_static.php Adds IonosTheme class to autoloader mapping
apps/theming/composer/composer/autoload_classmap.php Adds IonosTheme class to autoloader classmap
apps/theming/composer/composer/LICENSE Removes empty lines (formatting cleanup)
IONOS Adds submodule reference to IONOS configuration repository
.gitmodules Configures IONOS submodule with GitHub repository URL
Comments suppressed due to low confidence (1)

apps/theming/lib/Themes/IonosTheme.php:12

  • The class extends DefaultTheme but also explicitly implements ITheme. Since DefaultTheme already implements ITheme, the explicit implementation is redundant.
class IonosTheme extends DefaultTheme implements ITheme {

Comment on lines +35 to +45
return "
#header {
#nextcloud {
padding-inline-start: 220px;
.logo {
width: 200px;
}
}


Copilot AI Jul 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The large CSS string should be extracted to a separate method or external file for better maintainability. The current approach makes the method difficult to read and maintain.

Suggested change
return "
#header {
#nextcloud {
padding-inline-start: 220px;
.logo {
width: 200px;
}
}
return $this->getCustomCssContent();
}
private function getCustomCssContent(): string {
return "
#header {
#nextcloud {
padding-inline-start: 220px;
.logo {
width: 200px;
}
}

Copilot uses AI. Check for mistakes.
Comment thread apps/theming/lib/Themes/IonosTheme.php Outdated
// https://html.spec.whatwg.org/multipage/semantics.html#meta-color-scheme
return [[
'name' => 'color-scheme',
'content' => 'ionos',

Copilot AI Jul 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meta color-scheme content should be 'light' instead of 'ionos' as 'ionos' is not a valid CSS color-scheme value. Valid values are 'light', 'dark', or 'light dark'.

Suggested change
'content' => 'ionos',
'content' => 'light',

Copilot uses AI. Check for mistakes.
@bromiesTM
bromiesTM force-pushed the kh/dev/base-theme branch 7 times, most recently from 109c46a to 6a9a647 Compare July 24, 2025 11:23
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
@bromiesTM
bromiesTM force-pushed the kh/dev/base-theme branch from 6a9a647 to 9ca50d0 Compare July 24, 2025 11:30
@bromiesTM
bromiesTM merged commit ad92706 into ionos-dev Jul 28, 2025
12 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants