IONOS(ci): restore push builds on the per-major dev lanes (HDNEXT-2144) - #311
Merged
Merged
Conversation
The `on: push: branches:` list named unsuffixed `ionos-dev` and `ionos-stable`. GitHub evaluates the `on:` block from the pushed branch's own copy of the file, and this copy lives on `ionos-dev-v33`, which the list does not match — so pushes to this lane started no run at all. Observed: `ionos-dev-v32` has zero CI runs of any kind, ever, and `ionos-dev-v33`'s only runs were `pull_request` on 2026-07-13, while both received pushes on 2026-08-17. A month of commits on this lane, including the simplenavigation submodule work, has never been built. Glob the two entries so a per-major lane matches its own copy, and apply the same shape to the concurrency group, where the unmatched branch fell through to `head_ref || ref_name` with `cancel-in-progress: true` and so made consecutive pushes to this lane cancel each other instead of each taking a unique `run_id` key. Deliberately limited to the build-side gates. The `if:` conditions on `upload-to-artifactory`, on the ghcr push and on `trigger-remote-dev-workflow` list the same unsuffixed names and are left untouched, so this lane builds and tests but still publishes nothing and triggers nothing. Widening those is a separate change that needs the derived routing and the major assertion in place first: the trigger step posts `--form ref="main"`, which is the v30 lane, and that is precisely the 2026-07-29 accident. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
mk/ci/restore-push-builds-v33
branch
from
August 18, 2026 09:17
70450fa to
f350bbf
Compare
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This lane has not been building on push. The
on: push: branches:list names unsuffixedionos-devandionos-stable. GitHub evaluateson:from the pushed branch's own copy of the file, and this copy lives onionos-dev-v33— which the list does not match. So a push here starts no run.Observed:
ionos-dev-v32ionos-dev-v33pull_request, on 2026-07-13ionos-dev-v31ionos-dev-v30A month of commits on this lane — including the simplenavigation submodule work — has never been built.
What this changes
Two build-side gates only:
on: push: branches:—ionos-dev/ionos-stablebecomeionos-dev-v*/ionos-stable-v*.concurrency:group — the unmatched branch fell through tohead_ref || ref_namewithcancel-in-progress: true, so consecutive pushes to this lane cancelled each other instead of each taking a uniquerun_idkey.Both now match the shape already proven on
ionos-dev-v31, which is the branch whose pushes do build.What this deliberately does NOT change
The
if:conditions onupload-to-artifactory, onPush artifact to ghcr.ioand ontrigger-remote-dev-workflowlist the same unsuffixed names, and are left untouched. After this PR a push to this lane runsprepare-matrix,build-appsandhidrive-next-build, and all three of those jobs stay skipped — the lane builds and tests but publishes nothing and triggers nothing.That separation is the point. Widening the publish-side gates needs the derived routing and the major assertion in place first, because
trigger-remote-dev-workflowposts--form ref="main"— the v30 lane. A v33 build reaching that is exactly the 2026-07-29 accident. That work belongs to #195.Known hazard, pre-existing and not introduced here
upload-to-artifactoryand the ghcr push also fire onworkflow_dispatch, bypassing the branch list entirely — andARTIFACTORY_STAGE_PREFIXhas no arm matchingionos-dev-v33, so it stays at itsdevdefault, which is the unsuffixedionos-dev(v30) lane's path. So clicking "Run workflow" on this lane uploads a v33 artifact into v30's path. That is true today and unchanged by this PR; the fix is to derive the stage prefix from the lane, tracked in #202.Verification
Opening this PR builds the branch via the
pull_requestpaths filter, which also confirms the lane builds at all after a month. After merge, the next push toionos-dev-v33should start a run — that is the real proof.