IONOS(ci): converge the build workflow trigger set (HDNEXT-2144) - #319
Closed
printminion-co wants to merge 1 commit into
Closed
IONOS(ci): converge the build workflow trigger set (HDNEXT-2144)#319printminion-co wants to merge 1 commit into
printminion-co wants to merge 1 commit into
Conversation
Bring this branch's `on: push: branches:` list (and, where present, the concurrency group) onto the one converged form shared by every branch that builds. GitHub evaluates the `on:` block from the pushed branch's own copy, so a claim about "the" trigger set is only true once the copies agree. The list is the union of every live lane: the per-major globs, the legacy unsuffixed `ionos-dev`/`ionos-stable` lanes that are retired later, the trains in both naming eras, and user dev branches. Keeping the unsuffixed entries matters — `ionos-dev` does not match `ionos-dev-v*`, so dropping them would stop that branch matching its own copy and leave it dark, the same defect just fixed on the v32 and v33 lanes. No behaviour change on any branch: a branch's `on:` block only ever evaluates for pushes to that branch, and every branch still matches its own name. Nothing about which downstream ref is triggered, or about any published artifact, is touched. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Author
|
Closing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring this branch's
on: push: branches:list — and, where present, theconcurrency:group — onto the one converged form shared by every branch that builds the workflow.GitHub evaluates
on:from the pushed branch's own copy of the file, so any statement about "the" trigger set is wrong by construction until the copies agree. That is what made the v32/v33 lanes silently stop building (fixed in #311/#312), and it is why the later routing work needs this first.The converged list is the union of every live lane:
Keeping the unsuffixed entries is load-bearing.
ionos-devdoes not match the globionos-dev-v*— the glob requires a literal-v. Converging onto globs alone would stop that branch matching its own copy and leave it dark: exactly the defect just fixed on v32/v33, re-inflicted by the ticket meant to fix it. Those two entries are what a later ticket removes when it retires those branches.Why this is a no-op
A branch's
on:block only ever evaluates for pushes to that branch. Every branch still matches its own name after the change — verified across all seven before opening these PRs. So the union adds entries that can never fire from this copy, and removes nothing that could.Nothing about which downstream ref is triggered, or about any published artifact, is touched. The
if:gates onupload-to-artifactory, the ghcr push andtrigger-remote-dev-workfloware deliberately left alone — widening those needs the derived routing and the major assertion first, and belongs to #195.Note
ionos-devhas noconcurrency:block at all; that PR converges only theon:list, since adding a concurrency group there would be a real behaviour change rather than a no-op. Reconciling the workflow files wholesale (they range from 445 to 1084 lines) is fork-skew cleanup and explicitly out of scope.