Skip to content

allow dataset_y updates with multiple values - #49

Merged
Lance-Drane merged 8 commits into
developfrom
update_fix
Jul 28, 2026
Merged

allow dataset_y updates with multiple values#49
Lance-Drane merged 8 commits into
developfrom
update_fix

Conversation

@konstpieper

Copy link
Copy Markdown
Contributor

Lance, that is a fix that is needed for the recent merge that allows for multiple y values. I do not know when we plan to merge to main, but I believe this is small enough to go in right now. Let me know if you see any issues.

@konstpieper
konstpieper requested a review from Lance-Drane July 17, 2026 19:28
@konstpieper

Copy link
Copy Markdown
Contributor Author

@Lance-Drane I have also needed to make some changes to benchmarks, to get them to work on my end. They are entangled to some other changes that mostly affect the sable backend here: dc372f2
I may be able to disentangle some of those into separate commits, if you think that is worthwhile.

@Lance-Drane

Copy link
Copy Markdown
Contributor

This looks fine and I'm happy to approve (also think it'll be good to get this in before develop -> main), could you add that commit to the update_fix branch? Alternatively you can just change the target from update_fix to sable and I can merge it in.

- bump the SABLE version to get the newest features
- use the hyperparameter prior_std instead of alpha
- transition the sable backend and clients to use that feature, and
  clean up specification of unnecessary hyperparameters
- fix and adapt benchmarks to the new vesion
@konstpieper

Copy link
Copy Markdown
Contributor Author

I have cherry-picked the commit dc372f2. I have edited it to back out the changes to pyproject.toml. There are some updates to uv.lock, due to the new main sable version (0.1.0 -> 0.1.1). d60218d

@Lance-Drane

Copy link
Copy Markdown
Contributor

With the addition of torch as a dependency to Sable, we probably need to go ahead and make Sable an optional dependency. You'll need over 4G of python dependencies alone to build it now. I am going to go ahead and make this change on another branch based off of yours, if you are okay with that I think we should merge this.

This will go under [project.optional-dependencies] in pyproject.toml

In UV (for development) you install this via uv sync --all-extras

In Pip (for our users) you'd use pip install "dial[sable]"

Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Lance-Drane and others added 3 commits July 24, 2026 02:57
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
@Lance-Drane
Lance-Drane merged commit 6e7a898 into develop Jul 28, 2026
18 checks passed
@Lance-Drane
Lance-Drane deleted the update_fix branch July 28, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants