make gpax and sable optional dependencies - #51
Conversation
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
|
I think this is fine, but it will break unit tests and benchmarks depending on those backends. Do we have a mechanism to disable tests/benchmarks that use a specific backend? |
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Good catch, fixed in latest commit. You can use Examples: https://docs.pytest.org/en/stable/how-to/skipping.html#skip-xfail-with-parametrize This should work extremely well for unit tests. For benchmarks (where we reuse the parameters in contexts outside of the pytest statement), this is a little awkward because we really need to have a |
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
We can immediately merge #49 once this is merged into the update_fix branch.
Keeping scikit-learn as a required dependency for now to avoid breaking backwards compatibility, as it takes up very little space on its own (most of the space is taken up by scipy, which we want to have as a required dependency). This can be changed if desired.
Since Sable pulls in so many dependencies but is not necessarily a requirement for using DIAL, it is being moved to optional dependencies.
I have also moved gpax to be an optional dependency, the size is not really a problem here either but this is more due to it not receiving first class support + reportedly causing some people build issues (though I think these have been resolved).
Closes #46