refactor(core): remove upsert entities methods and related SQL statements - #1288
Merged
Conversation
…ents Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
christian-pinto
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the upsert-entity functionality from the samplestore. The
upsertEntitiesandupsertExperimentResultsmethods, the underlying SQL statements, and all related tests and fixtures are deleted. No new behaviour is introduced; this is a pure removal of unused code.High-level Changes
SQLSampleStore: Removed theupsertEntitiesandupsertExperimentResultsmethods.upsert_entitiesSQL statement (SQLite and MySQL variants).upsert_entities_to_sample_storefixture and the corresponding test.Impact
No existing functionality is affected — the removed methods were not called anywhere in the active codebase. Callers that relied on upsert semantics must now use the standard
addEntitiespath.