Summary
The entity upsert API in the sample store should be removed. This includes the methods that implement merge-on-insert behaviour for entities, the SQL statement builder that supports them, and the corresponding test coverage.
Motivation
The upsert behaviour — merging property values into an existing entity — is no longer a supported operation. The relevant methods have no callers outside of the test suite, meaning they are effectively dead code. Keeping them creates a misleading surface area in the API and maintenance overhead with no benefit. Removing them would make the supported path (plain insert) clearer and reduce the codebase to only what is actively used.
Scope
- The sample store implementation should have the upsert entity methods removed.
- The SQL statement builder layer should have the entity-upsert helper removed, while leaving resource-level upsert helpers untouched.
- The test suite should have the fixture and test case that cover the removed behaviour deleted.
Summary
The entity upsert API in the sample store should be removed. This includes the methods that implement merge-on-insert behaviour for entities, the SQL statement builder that supports them, and the corresponding test coverage.
Motivation
The upsert behaviour — merging property values into an existing entity — is no longer a supported operation. The relevant methods have no callers outside of the test suite, meaning they are effectively dead code. Keeping them creates a misleading surface area in the API and maintenance overhead with no benefit. Removing them would make the supported path (plain insert) clearer and reduce the codebase to only what is actively used.
Scope