Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FUTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ examples, evaluation harnesses, and pre-1.0 API freeze work.

Knolo Agents is deliberately **not** trying to become:

- A LangChain-style provider/orchestration framework with implicit tool discovery
- A provider/orchestration framework with implicit tool discovery
or hidden network access.
- A model provider, vector database, job queue, or application data layer.
- A place that vendors, re-exports, or ships `@knolo/core` storage
Expand Down
6 changes: 4 additions & 2 deletions crates/knolo-agent-icp/src/auth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,10 @@ mod tests {

#[test]
fn allowlist_enforced() {
let mut limits = RuntimeLimitsV1::default();
limits.allowed_callers = vec!["aaaaa-aa".into()];
let limits = RuntimeLimitsV1 {
allowed_callers: vec!["aaaaa-aa".into()],
..RuntimeLimitsV1::default()
};
let anon = Principal::anonymous();
assert!(require_run_access(anon, false, &limits).is_err());
assert!(require_run_access(anon, true, &limits).is_ok());
Expand Down
2 changes: 1 addition & 1 deletion crates/knolo-agent-icp/src/definition.rs
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ impl AgentDefinitionBundleV1 {
let node_implementation_hash =
format!("{:x}", Sha256::digest(bundle.implementation_id.as_bytes()));
let policy = match &bundle.pack {
Some(pack) => Some(pack.compile().map_err(|e| CoreError::PackLoad(e))?),
Some(pack) => Some(pack.compile().map_err(CoreError::PackLoad)?),
None => None,
};
Ok(LoadedDefinition {
Expand Down
6 changes: 4 additions & 2 deletions crates/knolo-agent-icp/src/stable_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -483,8 +483,10 @@ mod tests {
..RuntimeLimitsV1::default()
};
persist_limits(&limits).unwrap();
let mut budget = HostBudgetSnapshotV1::default();
budget.tool_calls = 3;
let budget = HostBudgetSnapshotV1 {
tool_calls: 3,
..HostBudgetSnapshotV1::default()
};
persist_budget(&budget).unwrap();
let snap = load_snapshot().unwrap();
assert_eq!(snap.limits.max_concurrent_executions, 4);
Expand Down
8 changes: 7 additions & 1 deletion scripts/hygiene.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@
set -euo pipefail
tracked=$(git ls-files)
for pattern in '(^|/)(node_modules|target|dist|\.venv|coverage)(/|$)' '(^|/)(requirements[^/]*\.txt|Pipfile|poetry\.lock|pyproject\.toml|setup\.py|setup\.cfg)$' '\.(pem|key|p12|pfx)$' '(^|/)\.env($|\.)'; do
if printf '%s\n' "$tracked" | rg -i "$pattern"; then echo "forbidden tracked artifact" >&2; exit 1; fi
# Prefer rg when present; fall back to grep so CI runners without ripgrep still work.
if command -v rg >/dev/null 2>&1; then
if printf '%s\n' "$tracked" | rg -i "$pattern"; then echo "forbidden tracked artifact" >&2; exit 1; fi
else
if printf '%s\n' "$tracked" | grep -Eie "$pattern"; then echo "forbidden tracked artifact" >&2; exit 1; fi
fi
done
# Product comparisons are allowed in README prose; legacy integrations,
# credentials, and source-level identity references remain forbidden.
Expand All @@ -12,3 +17,4 @@ if find . -type l -print -quit | grep -q .; then echo "symlinks require explicit
for dir in node_modules target dist .venv coverage; do
if find . -type d -name "$dir" -not -path './.git/*' -print -quit | grep -q .; then echo "generated directory present: $dir" >&2; exit 1; fi
done

Loading