fix(ci): green checks after ICP agent runtime merge - #19
Merged
Conversation
Address clippy -D warnings in knolo-agent-icp (redundant_closure, field_reassign_with_default), reword FUTURE.md to clear the legacy identity ban, and make hygiene.sh work without ripgrep on CI runners.
Replace the corrupt actions/setup-node SHA (unresolvable on runners) with v4.4.0, and rewrite the executor match to use ? so clippy -D warnings passes on Rust 1.97.
cache: pnpm requires pnpm on PATH before setup-node runs; this job enables pnpm via corepack afterward, so caching failed every TS matrix job.
Resolve workflow/runtime conflicts in favor of main's Node 24 and question_mark fixes. Retain clippy, hygiene, and FUTURE.md fixes from this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #18. That PR landed the ICP agent runtime, but CI was still red. This brings the remaining fixes onto
main:redundant_closure,field_reassign_with_default,question_mark)FUTURE.md; makehygiene.shwork withoutrgactions/setup-nodeSHA with v4.4.0; dropcache: pnpmuntil corepack enables pnpmTest plan
cargo clippy --workspace --all-targets -- -D warnings(Rust 1.97)cargo test --workspacecargo fmt --all --check