Repository navigation
Untangle the nested ternaries in e2e, common and three socket hooks (GRYT-1792, client stack 3) - #899
Merged
grytchat merged 2 commits intoOct 19, 2026
Conversation
This was referenced Oct 19, 2026
Merged
grytchat
marked this pull request as ready for review
October 19, 2026 09:30
…GRYT-1792, client stack 3) Twelve files. Sort comparators write their last step as `a < b ? -1 : Number(a > b)`. Longer chains became early-return functions (filteredAction, lostSince) or two named steps. The send-across-restart spec opens its conversation from a table keyed by kind. useCustomThemes looks a preset up first and a saved theme second, and still doesn't let a missing preset fall through to a saved theme. Same output for every input as before. The twelve files leave the nested-ternary exception list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grytchat
force-pushed
the
claude/GRYT-1792-client-ternary-3
branch
from
October 19, 2026 09:34
ded6753 to
9dc223c
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twelve files. Sort comparators write their last step as
a < b ? -1 : Number(a > b). Longer chains became early-return functions(filteredAction, lostSince) or two named steps. The send-across-restart
spec opens its conversation from a table keyed by kind. useCustomThemes
looks a preset up first and a saved theme second, and still doesn't let
a missing preset fall through to a saved theme.
Same output for every input as before. The twelve files leave the
nested-ternary exception list.
Part of a
gh stack: #897 → #898 → #899. They merge together withgh stack merge. On each layer locally:tsc -b, the CI ESLint command and all 171test:*check scripts pass. The exception isembedded-server-paths, which resolves the SFU relative topackages/and so fails in a standalone clone, on main too.Next after this stack: the 44 socket components, then the last socket hooks, lib, mls and webRTC files.
common/src/auth/keycloak.tsgets its own PR for review.Task: GRYT-1792
🤖 Generated with Claude Code