Repository navigation
Untangle the nested ternaries in electron/ and src/components (GRYT-1792, client stack 1) - #897
Merged
Merged
Conversation
…792, client stack 1) Twelve files. Each chain became a lookup table, an early-return function (ringStateOf, iconOpacity, splashMessage, volumeColour, flag), or separate conditions where JSX picked between pages. The status banner's message and glyph now come from one table, so the two can't disagree. check-embedded-starting builds the sidebar's ring state from source, so it picks up ringStateOf() as well. Same output for every input as before. The twelve files leave the nested-ternary exception list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grytchat
marked this pull request as ready for review
October 19, 2026 09:30
This was referenced Oct 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twelve files. Each chain became a lookup table, an early-return
function (ringStateOf, iconOpacity, splashMessage, volumeColour, flag),
or separate conditions where JSX picked between pages. The status
banner's message and glyph now come from one table, so the two can't
disagree. check-embedded-starting builds the sidebar's ring state from
source, so it picks up ringStateOf() as well.
Same output for every input as before. The twelve files leave the
nested-ternary exception list.
Part of a
gh stack: #897 → #898 → #899. They merge together withgh stack merge. On each layer locally:tsc -b, the CI ESLint command and all 171test:*check scripts pass. The exception isembedded-server-paths, which resolves the SFU relative topackages/and so fails in a standalone clone, on main too.Next after this stack: the 44 socket components, then the last socket hooks, lib, mls and webRTC files.
common/src/auth/keycloak.tsgets its own PR for review.Task: GRYT-1792
🤖 Generated with Claude Code