Skip to content

test(spanner): fix flaky readUnmatchableTypesTest #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lqiu96 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(spanner): fix flaky readUnmatchableTypesTest #4542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ...cloud/spring/data/spanner/core/convert/ConverterAwareMappingSpannerEntityReaderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.springframework.core.convert.ConversionFailedException;
import org.springframework.core.convert.ConverterNotFoundException;
import org.springframework.core.convert.converter.Converter;
import org.springframework.lang.Nullable;

Expand Down Expand Up @@ -276,11 +277,15 @@ void readUnmatchableTypesTest() {
assertThatThrownBy(() -> this.spannerEntityReader.read(
FaultyTestEntity.class,
struct,
java.util.Set.of("id"),
false
null, // includeColumns = null means read all columns
true // allowMissingColumns = true prevents failing early on the missing 'id' column
))
.isInstanceOf(SpannerDataException.class)
.hasMessageContaining("Unable to read column from Cloud Spanner results");
// We expect ConverterNotFoundException because:
// 1. The missing 'id' column is allowed and does not cause a failure.
// 2. The reader proceeds to process 'fieldWithUnsupportedType'.
// 3. Since there is no converter from String to TestEntity, Spring throws ConverterNotFoundException.
.isInstanceOf(ConverterNotFoundException.class)
.hasMessageContaining("No converter found capable of converting from type");
}

@Test
Expand Down
Loading