test(spanner): fix flaky readUnmatchableTypesTest - #4542
Open
lqiu96 wants to merge 1 commit into
Open
Conversation
lqiu96
force-pushed
the
fix-flaky-spanner-test
branch
from
July 9, 2026 20:31
888a708 to
5e0d909
Compare
Rewrite the test to actually test unmatchable types by allowing missing columns and asserting on the conversion exception. This avoids the flakiness caused by non-deterministic field processing order when checking for missing columns.
lqiu96
force-pushed
the
fix-flaky-spanner-test
branch
from
July 9, 2026 20:34
5e0d909 to
4ce7b15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the 'readUnmatchableTypesTest' to actually test unmatchable types instead of missing columns, resolving the flakiness caused by non-deterministic field reflection order.