Skip to content

fix: disable SSL for .onion domains in SOCKSSocket.connectTo #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sneurlax wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: disable SSL for .onion domains in SOCKSSocket.connectTo #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/socks_socket.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class SOCKSSocket {
StreamSubscription<List<int>>? get subscription => _subscription;

/// Is SSL enabled?
final bool sslEnabled;
bool sslEnabled;

/// Private constructor.
SOCKSSocket._(this.proxyHost, this.proxyPort, this.sslEnabled);
Expand Down Expand Up @@ -216,6 +216,12 @@ class SOCKSSocket {
/// Returns:
/// A Future that resolves to void.
Future<void> connectTo(String domain, int port) async {
// Onion services provide their own end-to-end encryption, so disable the
// TLS upgrade when connecting to a .onion domain.
if (domain.endsWith('.onion')) {
sslEnabled = false;
}

// Connect command.
var request = [
0x05, // SOCKS version.
Expand Down
Loading