fix: disable SSL for .onion domains in SOCKSSocket.connectTo#75
Open
sneurlax wants to merge 1 commit into
Open
fix: disable SSL for .onion domains in SOCKSSocket.connectTo#75sneurlax wants to merge 1 commit into
sneurlax wants to merge 1 commit into
Conversation
Onion services are already end-to-end encrypted by the Tor protocol, so attempting a TLS handshake on top of a .onion connection is unnecessary and fails against services that do not present a certificate. Skip the SSL upgrade automatically when the target domain ends with .onion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onion services are already end-to-end encrypted by the Tor protocol, so attempting a TLS handshake on top of a .onion connection is unnecessary and fails against services that do not present a certificate. Skip the SSL upgrade automatically when the target domain ends with .onion.
This comes from cypherstack/tor's divergences from your upstream Foundation-Devices/tor--we found this change useful and use it currently, but you can take it or leave it :)