Repository navigation
Make preflight platform tests independent of the test host - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux existing-output test failed on macOS because its shared path checker correctly consulted the actual platform and invoked tmutil. Explicitly mock Linux for that fixture and add a paired Darwin test confirming an existing Time Machine-included output directory is refused. Production preflight behavior is unchanged.
The CI unit-suite step now checks an anchored nonempty unittest summary instead of requiring exactly 361 tests. The runner exit status remains authoritative under pipefail, so failing tests still fail the job and zero discovered tests remain rejected.
Validation: all 362 local tests and tools/validate.py pass on macOS. Independent Astra review approved exact head 70ee554, independently reran the full suite and verified guard rejection cases and failure propagation. This repair is separate from the sequence audit in #64, which depends on it.