Repository navigation
fix: queue swipe choices, playlist library moves, offload on pause, likes order and group reordering - #1371
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Closes #1361
Closes #1364
Closes #1365
Closes #1367
Closes #1368
Change type
Validation
./gradlew :app:assembleGithubDebugpassed./gradlew :app:testGithubDebugUnitTestpassed: 4,252 tests in 682 classes, 0 failures, 3 skipped./gradlew ktlintCheckand./gradlew :app:compileFossDebugKotlinpassedTest device and Android version: Xiaomi 2311DRK48G, Android 16
Screenshots or recordings
Risk and compatibility
Two new player preferences,
queue_swipe_left_actionandqueue_swipe_right_action, with defaults when unset. No Room schema change: only new@Queryand@TransactionDAO methods.Playback: offload is switched off only after a 12 s pause while offloaded, and switched back on before playback resumes. Speed and pitch are compared to 1 within 0.0001, so a saved speed of 0.99999994 still counts as unchanged.
An Undo for a removed song does nothing if the queue before it has changed since the removal.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.