Repository navigation
fix(music): play AAC songs for their real length on macOS - #202
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
9 of 15 tasks
A-EDev
force-pushed
the
feat/music-side-pane
branch
from
October 25, 2026 19:36
eb89c34 to
75af58a
Compare
A-EDev
force-pushed
the
fix/music-aac-length
branch
from
October 25, 2026 19:36
ac8055b to
59cba8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Music player follow-up 3 of 4. Stacked on
feat/music-side-pane(PR #201); review and merge in order.approxDurationMs, or the song's own length for a download). When the element reports well past it, the player shows the listed length and ends the song there, so the next one starts on time.Related issue
Change type
Validation
pnpm test: 754 tests passed, 0 failedpnpm build: passedcargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: not run on this branch (no Rust changes); clean at the top of the stackcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); no new warnings at the top of the stackcargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); 825 passed, 0 failed at the top of the stackScreenshots or recordings
Risk and compatibility
v0.1.0-beta3.txt).