Skip to content

feat(music): drag the dock up to grow the full player out of it - #203

Merged
A-EDev merged 3 commits into
mainfrom
feat/music-mini-player
Oct 25, 2026
Merged

A-EDev merged 3 commits into
mainfrom
feat/music-mini-player

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Music player follow-up 4 of 4. Stacked on fix/music-aac-length (PR #202); review and merge in order.

  • Drag the music dock up with the mouse, or swipe up on it with two fingers, and the full player grows out of the dock under the pointer, as Android's player sheet does: the dock fades out over the first quarter, the player's content fades in and scales up, and a release flings or settles to the nearer end.
  • Opening and closing the player use the same growth, so it always sinks back into the dock. The seek line and the volume wheel keep their own gestures.
  • The dock is refreshed: larger rounded artwork with a playing animation, a clearer title, and a handle on hover. The separate expand button is gone; clicking the song or dragging the dock opens the player.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test: 764 tests passed, 0 failed
  • pnpm build: passed
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: passed
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: no new warnings against main
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 825 passed, 0 failed
  • I smoke-tested the affected desktop behavior. macOS: a short swipe sinks back, a long one opens the player, collapsing returns to the dock, a wheel on the seek line or a scroll down does nothing, and the dock is inert while the player is open.
  • OS/device: the owner tested a local build of the whole stack on macOS. Windows and Linux were not run.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed (changelog entry in v0.1.0-beta3.txt).
  • Dependency and lockfile changes are intentional and limited to this PR. No dependency changes.
  • Breaking changes and upgrade steps are clearly documented. No breaking changes.

Copilot AI balanced review requested due to automatic review settings October 25, 2026 19:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev force-pushed the fix/music-aac-length branch from ac8055b to 59cba8d Compare October 25, 2026 19:36
@A-EDev
A-EDev force-pushed the feat/music-mini-player branch from 28af1ac to 8618a64 Compare October 25, 2026 19:37
@A-EDev
A-EDev changed the base branch from fix/music-aac-length to main October 25, 2026 19:37
@A-EDev
A-EDev merged commit 28bac82 into main Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants