Repository navigation
feat(lyrics): add lrc.red and Unison, and reorder providers - #195
Merged
Merged
Conversation
9 of 15 tasks
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
A-EDev
force-pushed
the
fix/music-lyrics-matching
branch
from
October 25, 2026 19:34
d5f01ee to
81affc0
Compare
A-EDev
force-pushed
the
feat/lyrics-providers
branch
from
October 25, 2026 19:34
4fce595 to
cd44a1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 18 of 22 of the music player plan (Android parity). Stacked on
fix/music-lyrics-matching(PR #194); review and merge in order.lyrics_http_getonly reaches the providers' hosts over https, with a size cap and an 8 s timeout.Related issue
Change type
Validation
pnpm test: 654 tests passed, 0 failedpnpm build: passedcargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: cleancargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: no new warnings against main (compared at the top of the stack)cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 822 passed, 0 failed (allsync_*suites included)Screenshots or recordings
Risk and compatibility
v0.1.0-beta3.txt).