Skip to content

feat(lyrics): port Flow for Android's lyrics renderer - #196

Merged
A-EDev merged 8 commits into
mainfrom
feat/lyrics-display
Oct 25, 2026
Merged

A-EDev merged 8 commits into
mainfrom
feat/lyrics-display

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Part 19 of 22 of the music player plan (Android parity). Stacked on feat/lyrics-providers (PR #195); review and merge in order.

  • Android's lyrics panel, rows, motion and karaoke drawing ported: springs with the expressive motion tokens, staggered row motion, depth scale, alpha and blur by distance (no blur on Linux), word fill with a soft front, word lift, held-note glow, duets, background vocals, synthesized timing for line-synced lyrics, an instrumental indicator.
  • Only the sung line redraws per frame, and nothing runs while paused, hidden or out of view.
  • A lyrics menu: sync offset, choose source, edit, copy, save .lrc, alignment, translation and romanization.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test: 725 tests passed, 0 failed
  • pnpm build: passed
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: clean
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: no new warnings against main (compared at the top of the stack)
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 823 passed, 0 failed (all sync_* suites included)
  • I smoke-tested the affected desktop behavior. macOS: karaoke fill on the sung line in the side pane (screenshot); 0 frame callbacks while paused.
  • OS/device: device testing by the owner. The checks above ran on macOS 27 (Apple Silicon MacBook Pro, 120 Hz) in a dev build of the whole stack; Windows and Linux were not run.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed (changelog entry in v0.1.0-beta3.txt).
  • Dependency and lockfile changes are intentional and limited to this PR. No dependency changes.
  • Breaking changes and upgrade steps are clearly documented. No breaking changes.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev force-pushed the feat/lyrics-providers branch from 4fce595 to cd44a1c Compare October 25, 2026 19:34
@A-EDev
A-EDev force-pushed the feat/lyrics-display branch from c013623 to 0b19b64 Compare October 25, 2026 19:35
@A-EDev
A-EDev changed the base branch from feat/lyrics-providers to main October 25, 2026 19:35
@A-EDev
A-EDev merged commit 03260a4 into main Oct 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants