Skip to content

fix(lyrics): find the right lyrics more often - #194

Merged
A-EDev merged 9 commits into
mainfrom
fix/music-lyrics-matching
Oct 25, 2026
Merged

A-EDev merged 9 commits into
mainfrom
fix/music-lyrics-matching

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Part 17 of 22 of the music player plan (Android parity). Stacked on feat/video-equalizer (PR #193); review and merge in order.

  • An uncached BetterLyrics song is a miss instead of benching the provider for 10 minutes.
  • Android's LyricsMatching: version tags kept, primary artist sent, scored picks in LrcLib, KuGou and Paxsenix.
  • LyricsPlus uses its one live server, one lookup per song shared by every caller, started when the song starts, with Android's 4 s word-sync grace.
  • Downloaded lyrics show at once and are parsed; TTML blank lines skipped and romanization kept apart.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test: 645 tests passed, 0 failed
  • pnpm build: passed
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: not run on this branch (no Rust changes); clean at the top of the stack
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); no new warnings at the top of the stack
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); 825 passed, 0 failed at the top of the stack
  • I smoke-tested the affected desktop behavior. Not exercised in the app on its own; covered by unit tests only.
  • OS/device: device testing by the owner. The checks above ran on macOS 27 (Apple Silicon MacBook Pro, 120 Hz) in a dev build of the whole stack; Windows and Linux were not run.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed (changelog entry in v0.1.0-beta3.txt).
  • Dependency and lockfile changes are intentional and limited to this PR. No dependency changes.
  • Breaking changes and upgrade steps are clearly documented. No breaking changes.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev force-pushed the feat/video-equalizer branch from 3b2d538 to 847960c Compare October 25, 2026 19:34
@A-EDev
A-EDev force-pushed the fix/music-lyrics-matching branch from d5f01ee to 81affc0 Compare October 25, 2026 19:34
@A-EDev
A-EDev changed the base branch from feat/video-equalizer to main October 25, 2026 19:34
@A-EDev
A-EDev merged commit 5270ae5 into main Oct 25, 2026
1 check passed
@A-EDev
A-EDev deleted the fix/music-lyrics-matching branch October 29, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants