Skip to content

feat(music): music controls in the system tray - #191

Merged
A-EDev merged 4 commits into
mainfrom
feat/music-tray
Oct 25, 2026
Merged

A-EDev merged 4 commits into
mainfrom
feat/music-tray

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Part 14 of 22 of the music player plan (Android parity). Stacked on fix/settings-sync-themes (PR #190); review and merge in order.

  • A tray menu with the current song, Play/Pause, Previous, Next and Show Flow. On Linux it is off by default and only offered when the AppIndicator library is present, so a missing library never crashes the app.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test: 577 tests passed, 0 failed
  • pnpm build: passed
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: clean
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: no new warnings against main (compared at the top of the stack)
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 791 passed, 0 failed (all sync_* suites included)
  • I smoke-tested the affected desktop behavior. macOS: the tray icon appears in the menu bar.
  • OS/device: device testing by the owner. The checks above ran on macOS 27 (Apple Silicon MacBook Pro, 120 Hz) in a dev build of the whole stack; Windows and Linux were not run.

Screenshots or recordings

Risk and compatibility

  • Enables Tauri's tray-icon feature; the .deb/.rpm now depend on libayatana-appindicator3 and the AppImage bundles it.
  • New dependencies: Tauri's tray-icon feature; Linux-only libloading 0.7 (already in the lockfile).
  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed (changelog entry in v0.1.0-beta3.txt).
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Breaking changes and upgrade steps are clearly documented. No breaking changes.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev force-pushed the fix/settings-sync-themes branch from 8d5e419 to 26e2399 Compare October 25, 2026 19:33
@A-EDev
A-EDev changed the base branch from fix/settings-sync-themes to main October 25, 2026 19:33
@A-EDev
A-EDev merged commit aec1a63 into main Oct 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants