Repository navigation
Conversation
6 of 15 tasks
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 15 of 22 of the music player plan (Android parity). Stacked on
feat/music-tray(PR #191); review and merge in order.0020_scrobble_queue.sql) flushed with backoff.LASTFM_API_KEY/LASTFM_API_SECRET, with an own-key option.Related issue
Change type
Validation
pnpm test: 589 tests passed, 0 failedpnpm build: passedcargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: cleancargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: no new warnings against main (compared at the top of the stack)cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 820 passed, 0 failed (allsync_*suites included)Screenshots or recordings
Risk and compatibility
keyringandmd-5. CI passes two new secrets that must be set in the repo for Last.fm sign-in.keyring4,md-50.11, reqwest'sformfeature.LASTFM_API_KEY,LASTFM_API_SECRET); none are committed.v0.1.0-beta3.txt).