Skip to content

feat(themes): six more palettes, theme files, and two sync fixes - #190

Merged
A-EDev merged 4 commits into
mainfrom
fix/settings-sync-themes
Oct 25, 2026
Merged

A-EDev merged 4 commits into
mainfrom
fix/settings-sync-themes

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Part 13 of 22 of the music player plan (Android parity). Stacked on feat/sleep-timer-shared (PR #189); review and merge in order.

  • Android's six extra palettes (Deep Ocean, Gunmetal, Cosmic Void, Cyberpunk, Royal Gold, Cream Paper), checked against FlowPalettes.kt.
  • Custom themes can be exported (one or all) and imported, with fresh ids on clashes.
  • The music player background syncs between desktops, and skip silence no longer syncs in from Android while desktop cannot use it.
  • The integrations page, artist Radio and audio language names are translated.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test: 574 tests passed, 0 failed
  • pnpm build: passed
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: clean
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: no new warnings against main (compared at the top of the stack)
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 789 passed, 0 failed (all sync_* suites included)
  • I smoke-tested the affected desktop behavior. Not exercised in the app on its own; covered by unit tests only.
  • OS/device: device testing by the owner. The checks above ran on macOS 27 (Apple Silicon MacBook Pro, 120 Hz) in a dev build of the whole stack; Windows and Linux were not run.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed (changelog entry in v0.1.0-beta3.txt).
  • Dependency and lockfile changes are intentional and limited to this PR. No dependency changes.
  • Breaking changes and upgrade steps are clearly documented. No breaking changes.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 14:19
@A-EDev A-EDev mentioned this pull request Oct 24, 2026
10 of 15 tasks

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev force-pushed the feat/sleep-timer-shared branch from 286802e to 735c2a4 Compare October 25, 2026 19:32
@A-EDev
A-EDev force-pushed the fix/settings-sync-themes branch from 8d5e419 to 26e2399 Compare October 25, 2026 19:33
@A-EDev
A-EDev changed the base branch from feat/sleep-timer-shared to main October 25, 2026 19:33
@A-EDev
A-EDev merged commit 84f1337 into main Oct 25, 2026
1 check passed
@A-EDev
A-EDev deleted the fix/settings-sync-themes branch October 29, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants